On Tue, 14 Sep 2010 20:44:10 +0100
Alan Cox wrote:
> > Yes, hvc_push() reschedules. It doesn't sit in a tight loop burning
> > electrons!
> >
> > Can we do something safer&smarter here?
>
>
> Its a printk handler - better to lose the bytes than hang the box. I
> think the current code is prob
Alan Cox wrote:
> If you want to make that change then I guess you need to audit every
> other hvc driver first.
>
> But I never understood the point of the hvc layer anyway 8)
We've come to the same conclusion here. I think we're just going to drop
the hvc layer and make the driver a standard c
> Yes, hvc_push() reschedules. It doesn't sit in a tight loop burning
> electrons!
>
> Can we do something safer&smarter here?
Its a printk handler - better to lose the bytes than hang the box. I
think the current code is probably right.
___
Linuxppc-
Alan Cox wrote:
> Its a printk handler - better to lose the bytes than hang the box. I
> think the current code is probably right.
What do you think about this change:
http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-October/thread.html#76830
This is the original version of my patch. In it,
On Tue, 14 Sep 2010 12:17:21 -0700
Andrew Morton wrote:
> On Fri, 20 Aug 2010 13:45:21 -0500
> Timur Tabi wrote:
>
> > hvc_console_print() calls the HVC client driver's put_chars() callback
> > to write some characters to the console. If the callback returns 0, that
> > indicates that no chara
On Tue, 14 Sep 2010 14:25:34 -0500
Timur Tabi wrote:
> Alan Cox wrote:
> > Its a printk handler - better to lose the bytes than hang the box. I
> > think the current code is probably right.
>
> What do you think about this change:
>
> http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-October/
On Fri, 20 Aug 2010 13:45:21 -0500
Timur Tabi wrote:
> hvc_console_print() calls the HVC client driver's put_chars() callback
> to write some characters to the console. If the callback returns 0, that
> indicates that no characters were written (perhaps the output buffer is
> full), but hvc_cons
Andrew,
Would you please take a moment to review this patch I sent last month?
I'd like for it to be incorporated into 2.6.37, but I'm having a hard
time finding someone to consider it.
Thanks.
On Fri, Aug 20, 2010 at 1:45 PM, Timur Tabi wrote:
> hvc_console_print() calls the HVC client driver'
hvc_console_print() calls the HVC client driver's put_chars() callback
to write some characters to the console. If the callback returns 0, that
indicates that no characters were written (perhaps the output buffer is
full), but hvc_console_print() treats that as an error and discards the
rest of th
