Re: [PATCH] i2c: don't print error when adding adapter fails

2016-10-05 Thread Jean Delvare
On Tue, 9 Aug 2016 13:36:17 +0200, Wolfram Sang wrote: > The core will do this for us now. > > Signed-off-by: Wolfram Sang > --- > drivers/i2c/busses/i2c-amd756.c | 5 + > drivers/i2c/busses/i2c-at91.c | 2 -- > drivers/i2c/busses/i2c-axxia.c

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-14 Thread Wolfram Sang
On Tue, Aug 09, 2016 at 01:36:16PM +0200, Wolfram Sang wrote: > Since v4.8-rc1, the I2C core will print detailed information when adding an > I2C > adapter fails. So, drivers can skip this now. > > I am still undecided if I apply this as a single patch or break it out. But > for > reviewing,

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-10 Thread Laxman Dewangan
On Tuesday 09 August 2016 05:06 PM, Wolfram Sang wrote: The core will do this for us now. For i2c-tegra.c Acked-by: Laxman Dewangan

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-10 Thread Krzysztof Kozlowski
On 08/09/2016 01:36 PM, Wolfram Sang wrote: > The core will do this for us now. > > Signed-off-by: Wolfram Sang > --- (...) > drivers/i2c/busses/i2c-exynos5.c| 4 +--- > drivers/i2c/busses/i2c-s3c2410.c| 1 - For Exynos and S3C2410: Acked-by:

Re: [STLinux Kernel] [PATCH] i2c: don't print error when adding adapter fails

2016-08-10 Thread Patrice Chotard
On 08/09/2016 01:36 PM, Wolfram Sang wrote: > Since v4.8-rc1, the I2C core will print detailed information when adding an > I2C > adapter fails. So, drivers can skip this now. > > I am still undecided if I apply this as a single patch or break it out. But > for > reviewing, avoiding the patch

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-10 Thread Ludovic Desroches
On Tue, Aug 09, 2016 at 01:36:17PM +0200, Wolfram Sang wrote: > The core will do this for us now. > > Signed-off-by: Wolfram Sang > --- [...] > drivers/i2c/busses/i2c-at91.c | 2 -- Acked-by: Ludovic Desroches [...] >

RE: [PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Zhang, Sonic
nux-te...@vger.kernel.org Subject: Re: [PATCH] i2c: don't print error when adding adapter fails On Tue, Aug 09, 2016 at 01:36:17PM +0200, Wolfram Sang wrote: > The core will do this for us now. > > Signed-off-by: Wolfram Sang <wsa-...@sang-engineering.com> > --- > drivers/i2c/buss

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Joachim Eastwood
On 9 August 2016 at 13:36, Wolfram Sang wrote: > Since v4.8-rc1, the I2C core will print detailed information when adding an > I2C > adapter fails. So, drivers can skip this now. > > I am still undecided if I apply this as a single patch or break it out. But > for

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Ray Jui
Hi Wolfram, On 8/9/2016 4:36 AM, Wolfram Sang wrote: The core will do this for us now. Signed-off-by: Wolfram Sang [...] diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c index 19c843828fe2ca..8e3477f9297eda 100644 ---

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Vladimir Zapolskiy
On 09.08.2016 14:36, Wolfram Sang wrote: > The core will do this for us now. > > Signed-off-by: Wolfram Sang > --- For > drivers/i2c/busses/i2c-pnx.c| 4 +--- [snip] > diff --git a/drivers/i2c/busses/i2c-pnx.c b/drivers/i2c/busses/i2c-pnx.c > index

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Wolfram Sang
> >@@ -550,15 +550,10 @@ static int uniphier_fi2c_probe(struct platform_device > >*pdev) > > } > > > > ret = i2c_add_adapter(>adap); > >-if (ret) { > >-dev_err(dev, "failed to add I2C adapter\n"); > >-goto err; > >-} > >- > >-err: > > if (ret) > >

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Wolfram Sang
On Tue, Aug 09, 2016 at 01:57:40PM +0200, Uwe Kleine-König wrote: > Hello Wolfram, > > On Tue, Aug 09, 2016 at 01:36:17PM +0200, Wolfram Sang wrote: > > The core will do this for us now. > > Would be nice to point out the relevant commit that changed the core in > the commit log. I agree, but

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Neil Horman
On Tue, Aug 09, 2016 at 01:36:17PM +0200, Wolfram Sang wrote: > The core will do this for us now. > > Signed-off-by: Wolfram Sang > --- > drivers/i2c/busses/i2c-amd756.c | 5 + > drivers/i2c/busses/i2c-at91.c | 2 -- >

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Grygorii Strashko
On 08/09/2016 02:36 PM, Wolfram Sang wrote: The core will do this for us now. Signed-off-by: Wolfram Sang --- For: drivers/i2c/busses/i2c-davinci.c| 4 +--- drivers/i2c/busses/i2c-omap.c | 4 +--- Reviewed-by: Grygorii Strashko

[PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Wolfram Sang
Since v4.8-rc1, the I2C core will print detailed information when adding an I2C adapter fails. So, drivers can skip this now. I am still undecided if I apply this as a single patch or break it out. But for reviewing, avoiding the patch bomb is probably a good thing. Should go via subsystem tree,

[PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Wolfram Sang
The core will do this for us now. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-amd756.c | 5 + drivers/i2c/busses/i2c-at91.c | 2 -- drivers/i2c/busses/i2c-axxia.c | 8 +--- drivers/i2c/busses/i2c-bcm-iproc.c | 8

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Guenter Roeck
On 08/09/2016 04:36 AM, Wolfram Sang wrote: The core will do this for us now. Signed-off-by: Wolfram Sang --- [ ... ] diff --git a/drivers/i2c/busses/i2c-uniphier-f.c b/drivers/i2c/busses/i2c-uniphier-f.c index aeead0d27d1007..64318e69089439 100644 ---

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Thierry Reding
On Tue, Aug 09, 2016 at 01:36:17PM +0200, Wolfram Sang wrote: [...] > diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c > index b126dbaa47e370..d9979da11485ae 100644 > --- a/drivers/i2c/busses/i2c-tegra.c > +++ b/drivers/i2c/busses/i2c-tegra.c > @@ -932,10 +932,8 @@

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Heiko Stübner
Am Dienstag, 9. August 2016, 13:36:17 schrieb Wolfram Sang: > The core will do this for us now. > > Signed-off-by: Wolfram Sang > --- [...] > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c > index 2bc8b01153d619..3b87afe82f6394 100644 >

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Uwe Kleine-König
Hello Wolfram, On Tue, Aug 09, 2016 at 01:36:17PM +0200, Wolfram Sang wrote: > The core will do this for us now. Would be nice to point out the relevant commit that changed the core in the commit log. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Peter Korsgaard
> "Wolfram" == Wolfram Sang writes: > The core will do this for us now. > Signed-off-by: Wolfram Sang > --- > drivers/i2c/busses/i2c-ocores.c | 4 +--- For i2c-ocores.c: Acked-by: Peter Korsgaard