Re: [PATCH] i2c: powermac: don't workaround for keywest

2015-05-17 Thread Dan DeVoto
, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: Subject: Re: [PATCH] i2c: powermac: don't workaround for keywest To: w...@the-dreams.de Cc: linux-...@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Dan DeVoto dand1...@yahoo.com, Mark Elliott txliteb...@gmail.com Date: Monday, May 11, 2015, 4:26

Re: [PATCH] i2c: powermac: don't workaround for keywest

2015-05-11 Thread wsa
On Mon, May 11, 2015 at 08:14:47AM +1000, Benjamin Herrenschmidt wrote: On Sun, 2015-05-10 at 20:34 +0200, Wolfram Sang wrote: Okay, so this patch is bogus. I understand now that onyx uses another codec than TAS, so this change will regress on other machines. However, it shows that this

Re: [PATCH] i2c: powermac: don't workaround for keywest

2015-05-11 Thread Benjamin Herrenschmidt
On Mon, 2015-05-11 at 09:34 +0200, w...@the-dreams.de wrote: On Mon, May 11, 2015 at 08:14:47AM +1000, Benjamin Herrenschmidt wrote: On Sun, 2015-05-10 at 20:34 +0200, Wolfram Sang wrote: Okay, so this patch is bogus. I understand now that onyx uses another codec than TAS, so this change

Re: [PATCH] i2c: powermac: don't workaround for keywest

2015-05-10 Thread Benjamin Herrenschmidt
On Sun, 2015-05-10 at 20:34 +0200, Wolfram Sang wrote: Okay, so this patch is bogus. I understand now that onyx uses another codec than TAS, so this change will regress on other machines. However, it shows that this unconditional instantiation of the TAS breaks sound on Macintoshs which still

Re: [PATCH] i2c: powermac: don't workaround for keywest

2015-05-10 Thread Wolfram Sang
On Sat, May 09, 2015 at 07:23:33PM +0200, Wolfram Sang wrote: Commit 3a3dd0186f619b (i2c/powermac: Improve detection of devices from device-tree) added a codec device instantiation workaround unconditionally although it is only needed for onyx. Do it conditionally since keywest has its own

[PATCH] i2c: powermac: don't workaround for keywest

2015-05-09 Thread Wolfram Sang
Commit 3a3dd0186f619b (i2c/powermac: Improve detection of devices from device-tree) added a codec device instantiation workaround unconditionally although it is only needed for onyx. Do it conditionally since keywest has its own codec instantiation in the sound drivers. Thanks must go to