Re: [PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete

2009-02-19 Thread Kumar Gala
On Feb 6, 2009, at 8:00 AM, Timur Tabi wrote: The i2c_wait() function is using wait_event_interruptible_timeout() to wait for the I2C controller to signal that it has completed an I2C bus operation. If the process that causes the I2C operation terminated abruptly, the wait will be

Re: [PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete

2009-02-10 Thread Timur Tabi
On Fri, Feb 6, 2009 at 8:00 AM, Timur Tabi ti...@freescale.com wrote: The i2c_wait() function is using wait_event_interruptible_timeout() to wait for the I2C controller to signal that it has completed an I2C bus operation. If the process that causes the I2C operation terminated abruptly, the

Re: [PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete

2009-02-10 Thread Wolfram Sang
On Fri, Feb 06, 2009 at 08:00:37AM -0600, Timur Tabi wrote: The i2c_wait() function is using wait_event_interruptible_timeout() to wait for the I2C controller to signal that it has completed an I2C bus operation. If the process that causes the I2C operation terminated abruptly, the wait will

Re: [PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete

2009-02-10 Thread Jean Delvare
On Tue, 10 Feb 2009 08:59:57 -0600, Timur Tabi wrote: On Fri, Feb 6, 2009 at 8:00 AM, Timur Tabi ti...@freescale.com wrote: The i2c_wait() function is using wait_event_interruptible_timeout() to wait for the I2C controller to signal that it has completed an I2C bus operation. If the

Re: [PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete

2009-02-10 Thread Timur Tabi
Jean Delvare wrote: No, that's something for either Ben Dooks (Cc'd) or the powerpc tree. This patch has nothing to do with ARM, so Kumar will pick it up, if you ACK it. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list

Re: [PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete

2009-02-10 Thread Jean Delvare
On Tue, 10 Feb 2009 10:01:54 -0600, Timur Tabi wrote: Jean Delvare wrote: No, that's something for either Ben Dooks (Cc'd) or the powerpc tree. This patch has nothing to do with ARM, so Kumar will pick it up, if you ACK it. Why are you mentioning ARM? From MAINTAINERS: I2C SUBSYSTEM P:

Re: [PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete

2009-02-10 Thread Timur Tabi
Jean Delvare wrote: To the best of my knowledge i2c-mpc falls into the embedded platforms category and is thus under Ben's responsibility. I don't see his Signed-off-by on any patch to i2c-mpc.c for the past three years (at least). I do see yours, however. You have directly applied similar

Re: [PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete

2009-02-10 Thread Ben Dooks
On Tue, Feb 10, 2009 at 10:21:04AM -0600, Timur Tabi wrote: Jean Delvare wrote: To the best of my knowledge i2c-mpc falls into the embedded platforms category and is thus under Ben's responsibility. I don't see his Signed-off-by on any patch to i2c-mpc.c for the past three years (at

Re: [PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete

2009-02-10 Thread Ben Dooks
On Fri, Feb 06, 2009 at 08:00:37AM -0600, Timur Tabi wrote: The i2c_wait() function is using wait_event_interruptible_timeout() to wait for the I2C controller to signal that it has completed an I2C bus operation. If the process that causes the I2C operation terminated abruptly, the wait will

[PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete

2009-02-06 Thread Timur Tabi
The i2c_wait() function is using wait_event_interruptible_timeout() to wait for the I2C controller to signal that it has completed an I2C bus operation. If the process that causes the I2C operation terminated abruptly, the wait will be interrupted, returning an error. It is better to let the I2C