Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-03-15 Thread Andrea Righi
On Thu, Mar 16, 2023 at 01:18:23AM +0900, Masahiro Yamada wrote: > On Tue, Mar 14, 2023 at 11:38 PM Andrea Righi > wrote: > > > > On Mon, Mar 13, 2023 at 11:09:31PM +0100, Andrea Righi wrote: > > > On Mon, Mar 13, 2023 at 11:02:34PM +0100, Michal Suchánek wrote: > > > > On Mon, Mar 13, 2023 at

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-03-15 Thread Masahiro Yamada
On Tue, Mar 14, 2023 at 11:38 PM Andrea Righi wrote: > > On Mon, Mar 13, 2023 at 11:09:31PM +0100, Andrea Righi wrote: > > On Mon, Mar 13, 2023 at 11:02:34PM +0100, Michal Suchánek wrote: > > > On Mon, Mar 13, 2023 at 10:53:34PM +0100, Andrea Righi wrote: > > > > On Mon, Mar 13, 2023 at

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-03-15 Thread Andrea Righi
On Wed, Mar 15, 2023 at 01:15:03AM +0100, Vincenzo Palazzo wrote: > > In practice, this is what I'm testing at the moment: > > > > --- > > diff --git a/arch/powerpc/kernel/module_64.c > > b/arch/powerpc/kernel/module_64.c > > index ff045644f13f..ea6c830ed1e7 100644 > > ---

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-03-14 Thread Vincenzo Palazzo
> In practice, this is what I'm testing at the moment: > > --- > diff --git a/arch/powerpc/kernel/module_64.c b/arch/powerpc/kernel/module_64.c > index ff045644f13f..ea6c830ed1e7 100644 > --- a/arch/powerpc/kernel/module_64.c > +++ b/arch/powerpc/kernel/module_64.c > @@ -234,12 +234,13 @@ static

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-03-14 Thread Andrea Righi
On Tue, Mar 14, 2023 at 03:38:24PM +0100, Andrea Righi wrote: > On Mon, Mar 13, 2023 at 11:09:31PM +0100, Andrea Righi wrote: > > On Mon, Mar 13, 2023 at 11:02:34PM +0100, Michal Suchánek wrote: > > > On Mon, Mar 13, 2023 at 10:53:34PM +0100, Andrea Righi wrote: > > > > On Mon, Mar 13, 2023 at

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-03-14 Thread Andrea Righi
On Mon, Mar 13, 2023 at 11:09:31PM +0100, Andrea Righi wrote: > On Mon, Mar 13, 2023 at 11:02:34PM +0100, Michal Suchánek wrote: > > On Mon, Mar 13, 2023 at 10:53:34PM +0100, Andrea Righi wrote: > > > On Mon, Mar 13, 2023 at 10:48:53PM +0100, Michal Suchánek wrote: > > > > Hello, > > > > > > > >

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-03-13 Thread Andrea Righi
On Mon, Mar 13, 2023 at 11:02:34PM +0100, Michal Suchánek wrote: > On Mon, Mar 13, 2023 at 10:53:34PM +0100, Andrea Righi wrote: > > On Mon, Mar 13, 2023 at 10:48:53PM +0100, Michal Suchánek wrote: > > > Hello, > > > > > > On Mon, Mar 13, 2023 at 09:32:16PM +0100, Andrea Righi wrote: > > > > On

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-03-13 Thread Michal Suchánek
On Mon, Mar 13, 2023 at 10:53:34PM +0100, Andrea Righi wrote: > On Mon, Mar 13, 2023 at 10:48:53PM +0100, Michal Suchánek wrote: > > Hello, > > > > On Mon, Mar 13, 2023 at 09:32:16PM +0100, Andrea Righi wrote: > > > On Wed, Jan 11, 2023 at 04:11:51PM +, Gary Guo wrote: > > > > Currently

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-03-13 Thread Andrea Righi
On Mon, Mar 13, 2023 at 10:48:53PM +0100, Michal Suchánek wrote: > Hello, > > On Mon, Mar 13, 2023 at 09:32:16PM +0100, Andrea Righi wrote: > > On Wed, Jan 11, 2023 at 04:11:51PM +, Gary Guo wrote: > > > Currently modversion uses a fixed size array of size (64 - sizeof(long)) > > > to store

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-03-13 Thread Michal Suchánek
Hello, On Mon, Mar 13, 2023 at 09:32:16PM +0100, Andrea Righi wrote: > On Wed, Jan 11, 2023 at 04:11:51PM +, Gary Guo wrote: > > Currently modversion uses a fixed size array of size (64 - sizeof(long)) > > to store symbol names, thus placing a hard limit on length of symbols. > > Rust symbols

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-03-13 Thread Andrea Righi
On Wed, Jan 11, 2023 at 04:11:51PM +, Gary Guo wrote: > Currently modversion uses a fixed size array of size (64 - sizeof(long)) > to store symbol names, thus placing a hard limit on length of symbols. > Rust symbols (which encodes crate and module names) can be quite a bit > longer. The

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-01-19 Thread Miguel Ojeda
On Wed, Jan 18, 2023 at 8:02 AM Masahiro Yamada wrote: > > - *.mod.c is kept human readable. On the topic of `.mod.c` readability: for approaches that may be less readable, we could improve that by adding some extra comments or rearrange things in a different way (it is a generated file,

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-01-19 Thread Lucas De Marchi
On Wed, Jan 18, 2023 at 04:01:29PM +0900, Masahiro Yamada wrote: On Wed, Jan 18, 2023 at 4:23 AM Lucas De Marchi wrote: On Tue, Jan 17, 2023 at 06:51:44PM +0100, Michal Suchánek wrote: >Hello, > >On Fri, Jan 13, 2023 at 06:18:41PM +, Gary Guo wrote: >> On Thu, 12 Jan 2023 14:40:59 -0700

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-01-19 Thread Gary Guo
On Thu, 19 Jan 2023 16:18:57 +0100 Michal Suchánek wrote: > On Thu, Jan 19, 2023 at 03:09:36PM +, Gary Guo wrote: > > On Tue, 17 Jan 2023 11:22:45 -0800 > > Lucas De Marchi wrote: > > > > > And the additional 0's should compress well > > > so I'm not sure the additional size is that much

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-01-19 Thread Michal Suchánek
On Thu, Jan 19, 2023 at 03:09:36PM +, Gary Guo wrote: > On Tue, 17 Jan 2023 11:22:45 -0800 > Lucas De Marchi wrote: > > > On Tue, Jan 17, 2023 at 06:51:44PM +0100, Michal Suchánek wrote: > > >Hello, > > > > > >On Fri, Jan 13, 2023 at 06:18:41PM +, Gary Guo wrote: > > >> On Thu, 12 Jan

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-01-19 Thread Gary Guo
On Tue, 17 Jan 2023 11:22:45 -0800 Lucas De Marchi wrote: > On Tue, Jan 17, 2023 at 06:51:44PM +0100, Michal Suchánek wrote: > >Hello, > > > >On Fri, Jan 13, 2023 at 06:18:41PM +, Gary Guo wrote: > >> On Thu, 12 Jan 2023 14:40:59 -0700 > >> Lucas De Marchi wrote: > >> > >> > On Wed, Jan

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-01-17 Thread Masahiro Yamada
On Wed, Jan 18, 2023 at 4:23 AM Lucas De Marchi wrote: > > On Tue, Jan 17, 2023 at 06:51:44PM +0100, Michal Suchánek wrote: > >Hello, > > > >On Fri, Jan 13, 2023 at 06:18:41PM +, Gary Guo wrote: > >> On Thu, 12 Jan 2023 14:40:59 -0700 > >> Lucas De Marchi wrote: > >> > >> > On Wed, Jan 11,

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-01-17 Thread Lucas De Marchi
On Tue, Jan 17, 2023 at 06:51:44PM +0100, Michal Suchánek wrote: Hello, On Fri, Jan 13, 2023 at 06:18:41PM +, Gary Guo wrote: On Thu, 12 Jan 2023 14:40:59 -0700 Lucas De Marchi wrote: > On Wed, Jan 11, 2023 at 04:11:51PM +, Gary Guo wrote: > > > > struct modversion_info { > >-

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-01-17 Thread Michal Suchánek
Hello, On Fri, Jan 13, 2023 at 06:18:41PM +, Gary Guo wrote: > On Thu, 12 Jan 2023 14:40:59 -0700 > Lucas De Marchi wrote: > > > On Wed, Jan 11, 2023 at 04:11:51PM +, Gary Guo wrote: > > > > > > struct modversion_info { > > >- unsigned long crc; > > >- char name[MODULE_NAME_LEN]; > >

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-01-13 Thread Lucas De Marchi
On Wed, Jan 11, 2023 at 04:11:51PM +, Gary Guo wrote: Currently modversion uses a fixed size array of size (64 - sizeof(long)) to store symbol names, thus placing a hard limit on length of symbols. Rust symbols (which encodes crate and module names) can be quite a bit longer. The length

Re: [PATCH] modpost: support arbitrary symbol length in modversion

2023-01-13 Thread Gary Guo
On Thu, 12 Jan 2023 14:40:59 -0700 Lucas De Marchi wrote: > On Wed, Jan 11, 2023 at 04:11:51PM +, Gary Guo wrote: > > > > struct modversion_info { > >-unsigned long crc; > >-char name[MODULE_NAME_LEN]; > >+/* Offset of the next modversion entry in relation to this one. */ > >+

[PATCH] modpost: support arbitrary symbol length in modversion

2023-01-11 Thread Gary Guo
Currently modversion uses a fixed size array of size (64 - sizeof(long)) to store symbol names, thus placing a hard limit on length of symbols. Rust symbols (which encodes crate and module names) can be quite a bit longer. The length limit in kallsyms is increased to 512 for this reason. It's a