Re: [PATCH] mpc52xx-psc-spi: refactor probe and remove to make use of of_register_spi_devices()

2009-11-02 Thread Wolfram Sang
Hi Grant, the patch referenced above is a little ugly. Adding the call should Agreed. I just referenced it to show there are more people wanting this feature. be really simple. I've drafted a patch to do only that step and attached it to this mail. If this one works for you, then I'll

Re: [PATCH] mpc52xx-psc-spi: refactor probe and remove to make use of of_register_spi_devices()

2009-11-02 Thread Grant Likely
On Mon, Nov 2, 2009 at 6:14 AM, Wolfram Sang w.s...@pengutronix.de wrote: Also, I'm resistant to changing the probe layout on this driver at this time.  With the work being done to generalize the OF support code, there is a strong possibility that of_platform will be deprecated in favor of

Re: [PATCH] mpc52xx-psc-spi: refactor probe and remove to make use of of_register_spi_devices()

2009-10-31 Thread Wolfram Sang
Hi Stephen, static struct of_platform_driver mpc52xx_psc_spi_of_driver = { .owner = THIS_MODULE, - .name = mpc52xx-psc-spi, + .name = DRIVER_NAME, You no longer need to set either owner or name in the of_platform driver, just in the included struct driver (as is done below),

Re: [PATCH] mpc52xx-psc-spi: refactor probe and remove to make use of of_register_spi_devices()

2009-10-31 Thread Grant Likely
Hi Wolfram, Thanks for this work. Comments below. On Fri, Oct 30, 2009 at 1:44 PM, Wolfram Sang w.s...@pengutronix.de wrote: This driver has a generic part for the probe/remove routines which probably used to be called from a platform driver and an of_platform driver. Meanwhile, the driver is

[PATCH] mpc52xx-psc-spi: refactor probe and remove to make use of of_register_spi_devices()

2009-10-30 Thread Wolfram Sang
This driver has a generic part for the probe/remove routines which probably used to be called from a platform driver and an of_platform driver. Meanwhile, the driver is of_platform only, so there is no need for the generic part anymore. Unifying probe/remove finally enables us to call

Re: [PATCH] mpc52xx-psc-spi: refactor probe and remove to make use of of_register_spi_devices()

2009-10-30 Thread Stephen Rothwell
Hi Wolfram, On Fri, 30 Oct 2009 20:44:12 +0100 Wolfram Sang w.s...@pengutronix.de wrote: static struct of_platform_driver mpc52xx_psc_spi_of_driver = { .owner = THIS_MODULE, - .name = mpc52xx-psc-spi, + .name = DRIVER_NAME, You no longer need to set either owner or name in