Re: [PATCH] mpc832x_rdb.c: prevent using uninitialized variable

On Thu, Jul 26, 2007 at 11:48:33AM -0500, Scott Wood wrote: > On Thu, Jul 26, 2007 at 06:01:39PM +0400, Anton Vorontsov wrote: > > If CONFIG_PCI undefined, np will be used uninitialized, thereby > > find_node_by_name(np, "par_io") will fail. > > This is the wrong fix -- you should be passing NULL

Re: [PATCH] mpc832x_rdb.c: prevent using uninitialized variable

On Thu, Jul 26, 2007 at 06:01:39PM +0400, Anton Vorontsov wrote: > If CONFIG_PCI undefined, np will be used uninitialized, thereby > find_node_by_name(np, "par_io") will fail. This is the wrong fix -- you should be passing NULL to the par_io call rather than np. Otherwise, if the par_io is earlie

[PATCH] mpc832x_rdb.c: prevent using uninitialized variable

If CONFIG_PCI undefined, np will be used uninitialized, thereby find_node_by_name(np, "par_io") will fail. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- arch/powerpc/platforms/83xx/mpc832x_rdb.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/plat