Re: [PATCH] powerpc/32s: Fix napping restore in data storage interrupt (DSI)

2021-08-13 Thread Michael Ellerman
On Tue, 3 Aug 2021 15:14:27 + (UTC), Christophe Leroy wrote: > When a DSI (Data Storage Interrupt) is taken while in NAP mode, > r11 doesn't survive the call to power_save_ppc32_restore(). > > So use r1 instead of r11 as they both contain the virtual stack > pointer at that point. Applied to

Re: [PATCH] powerpc/32s: Fix napping restore in data storage interrupt (DSI)

2021-08-04 Thread Finn Thain
On Wed, 4 Aug 2021, Christophe Leroy wrote: > > This patch is related to the bisect you did that pointed to 4c0104a83fc3 > ("powerpc/32: Dismantle EXC_XFER_STD/LITE/TEMPLATE") > > I think maybe the starting point should be to (manually) apply the patch > on top of that commit in order to

Re: [PATCH] powerpc/32s: Fix napping restore in data storage interrupt (DSI)

2021-08-04 Thread Nicholas Piggin
Excerpts from Christophe Leroy's message of August 4, 2021 11:28 pm: > > > Le 04/08/2021 à 13:36, Nicholas Piggin a écrit : >> Excerpts from Christophe Leroy's message of August 4, 2021 4:21 pm: >>> Hi Nic, >>> >>> I think I'll need your help on that one. >>> >>> Le 04/08/2021 à 08:07,

Re: [PATCH] powerpc/32s: Fix napping restore in data storage interrupt (DSI)

2021-08-04 Thread Christophe Leroy
Le 04/08/2021 à 13:36, Nicholas Piggin a écrit : Excerpts from Christophe Leroy's message of August 4, 2021 4:21 pm: Hi Nic, I think I'll need your help on that one. Le 04/08/2021 à 08:07, Christophe Leroy a écrit : Le 04/08/2021 à 06:04, Finn Thain a écrit : Hi Finn! On Tue, 3 Aug

Re: [PATCH] powerpc/32s: Fix napping restore in data storage interrupt (DSI)

2021-08-04 Thread Nicholas Piggin
Excerpts from Christophe Leroy's message of August 4, 2021 4:21 pm: > Hi Nic, > > I think I'll need your help on that one. > > Le 04/08/2021 à 08:07, Christophe Leroy a écrit : >> >> >> Le 04/08/2021 à 06:04, Finn Thain a écrit : Hi Finn! >>> On Tue, 3 Aug 2021, Christophe Leroy wrote: >>> >

Re: [PATCH] powerpc/32s: Fix napping restore in data storage interrupt (DSI)

2021-08-04 Thread Christophe Leroy
Hi Nic, I think I'll need your help on that one. Le 04/08/2021 à 08:07, Christophe Leroy a écrit : Le 04/08/2021 à 06:04, Finn Thain a écrit : On Tue, 3 Aug 2021, Christophe Leroy wrote: ... [ cut here ] kernel BUG at arch/powerpc/kernel/interrupt.c:49! Oops:

Re: [PATCH] powerpc/32s: Fix napping restore in data storage interrupt (DSI)

2021-08-04 Thread Christophe Leroy
Le 04/08/2021 à 06:04, Finn Thain a écrit : On Tue, 3 Aug 2021, Christophe Leroy wrote: When a DSI (Data Storage Interrupt) is taken while in NAP mode, r11 doesn't survive the call to power_save_ppc32_restore(). So use r1 instead of r11 as they both contain the virtual stack pointer at

Re: [PATCH] powerpc/32s: Fix napping restore in data storage interrupt (DSI)

2021-08-03 Thread Finn Thain
On Tue, 3 Aug 2021, Christophe Leroy wrote: > When a DSI (Data Storage Interrupt) is taken while in NAP mode, r11 > doesn't survive the call to power_save_ppc32_restore(). > > So use r1 instead of r11 as they both contain the virtual stack pointer > at that point. > > Reported-by: Finn Thain

[PATCH] powerpc/32s: Fix napping restore in data storage interrupt (DSI)

2021-08-03 Thread Christophe Leroy
When a DSI (Data Storage Interrupt) is taken while in NAP mode, r11 doesn't survive the call to power_save_ppc32_restore(). So use r1 instead of r11 as they both contain the virtual stack pointer at that point. Reported-by: Finn Thain Fixes: 4c0104a83fc3 ("powerpc/32: Dismantle