Re: [PATCH] powerpc/64s/hash: Fix hash_preload running with interrupts enabled

2020-08-02 Thread Michael Ellerman
On Mon, 27 Jul 2020 16:09:47 +1000, Nicholas Piggin wrote: > Commit 2f92447f9f96 ("powerpc/book3s64/hash: Use the pte_t address from the > caller") removed the local_irq_disable from hash_preload, but it was > required for more than just the page table walk: the hash pte busy bit is > effectively

Re: [PATCH] powerpc/64s/hash: Fix hash_preload running with interrupts enabled

2020-07-28 Thread Athira Rajeev
> On 28-Jul-2020, at 6:14 AM, Michael Ellerman wrote: > > Athira Rajeev writes: >>> On 27-Jul-2020, at 6:05 PM, Michael Ellerman wrote: >>> >>> Athira Rajeev writes: > On 27-Jul-2020, at 11:39 AM, Nicholas Piggin wrote: > > Commit 2f92447f9f96 ("powerpc/book3s64/hash: Use

Re: [PATCH] powerpc/64s/hash: Fix hash_preload running with interrupts enabled

2020-07-27 Thread Michael Ellerman
Athira Rajeev writes: >> On 27-Jul-2020, at 6:05 PM, Michael Ellerman wrote: >> >> Athira Rajeev writes: On 27-Jul-2020, at 11:39 AM, Nicholas Piggin wrote: Commit 2f92447f9f96 ("powerpc/book3s64/hash: Use the pte_t address from the caller") removed the local_irq_disable

Re: [PATCH] powerpc/64s/hash: Fix hash_preload running with interrupts enabled

2020-07-27 Thread Athira Rajeev
> On 27-Jul-2020, at 6:05 PM, Michael Ellerman wrote: > > Athira Rajeev writes: >>> On 27-Jul-2020, at 11:39 AM, Nicholas Piggin wrote: >>> >>> Commit 2f92447f9f96 ("powerpc/book3s64/hash: Use the pte_t address from the >>> caller") removed the local_irq_disable from hash_preload, but it

Re: [PATCH] powerpc/64s/hash: Fix hash_preload running with interrupts enabled

2020-07-27 Thread Michael Ellerman
Athira Rajeev writes: >> On 27-Jul-2020, at 11:39 AM, Nicholas Piggin wrote: >> >> Commit 2f92447f9f96 ("powerpc/book3s64/hash: Use the pte_t address from the >> caller") removed the local_irq_disable from hash_preload, but it was >> required for more than just the page table walk: the hash pte

Re: [PATCH] powerpc/64s/hash: Fix hash_preload running with interrupts enabled

2020-07-27 Thread Athira Rajeev
> On 27-Jul-2020, at 11:39 AM, Nicholas Piggin wrote: > > Commit 2f92447f9f96 ("powerpc/book3s64/hash: Use the pte_t address from the > caller") removed the local_irq_disable from hash_preload, but it was > required for more than just the page table walk: the hash pte busy bit is >

[PATCH] powerpc/64s/hash: Fix hash_preload running with interrupts enabled

2020-07-27 Thread Nicholas Piggin
Commit 2f92447f9f96 ("powerpc/book3s64/hash: Use the pte_t address from the caller") removed the local_irq_disable from hash_preload, but it was required for more than just the page table walk: the hash pte busy bit is effectively a lock which may be taken in interrupt context, and the local