Re: [PATCH] powerpc/fsl_soc: Search all global-utilities nodes for rstccr

2010-08-31 Thread Matthew McClintock
On Aug 28, 2010, at 5:34 PM, Timur Tabi wrote: m...@freescale.com wrote: + + for_each_node_by_name(np, global-utilities) { + if ((of_get_property(np, fsl,has-rstcr, NULL))) { + rstcr = of_iomap(np, 0) + 0xb0; + if (!rstcr)

Re: [PATCH] powerpc/fsl_soc: Search all global-utilities nodes for rstccr

2010-08-31 Thread Timur Tabi
On Tue, Aug 31, 2010 at 11:26 AM, Matthew McClintock m...@freescale.com wrote: I'm not sure KERN_EMERG is warranted for this kind of error. I'm not sure either - I left it as it was before. My vote is to change it to KERN_ERR, but it's your call. So if a node has an fsl,rstcr property, but

Re: [PATCH] powerpc/fsl_soc: Search all global-utilities nodes for rstccr

2010-08-28 Thread Timur Tabi
m...@freescale.com wrote: + +       for_each_node_by_name(np, global-utilities) { +               if ((of_get_property(np, fsl,has-rstcr, NULL))) { +                       rstcr = of_iomap(np, 0) + 0xb0; +                       if (!rstcr) +                               printk (KERN_EMERG

[PATCH] powerpc/fsl_soc: Search all global-utilities nodes for rstccr

2010-08-27 Thread Matthew McClintock
The first global-utilities node might not contain the rstcr property, so we should search all the nodes Signed-off-by: Matthew McClintock m...@freescale.com --- arch/powerpc/sysdev/fsl_soc.c | 20 +++- 1 files changed, 11 insertions(+), 9 deletions(-) diff --git