Re: [PATCH] powerpc/mm: Fix 40x and 8xx vs. _PAGE_SPECIAL

2009-09-23 Thread Weirich, Bernhard
:12 An: Weirich, Bernhard; Rex Feany Cc: linuxppc-dev list Betreff: [PATCH] powerpc/mm: Fix 40x and 8xx vs. _PAGE_SPECIAL The test to check whether we have _PAGE_SPECIAL defined is broken, since we always define it, just not always to a meaninful value :-) That broke 8xx and 40x under some

Re: [PATCH] powerpc/mm: Fix 40x and 8xx vs. _PAGE_SPECIAL

2009-09-23 Thread Rex Feany
Thus spake Benjamin Herrenschmidt (b...@kernel.crashing.org): Bernhard, Rex, please let me know if that works for you. it doesn't work for me, it crashes differently then before though! This patch worked for me: Signed-off-by: Bernhard Weirich bernhard.weir...@riedel.net ---

Re: [PATCH] powerpc/mm: Fix 40x and 8xx vs. _PAGE_SPECIAL

2009-09-23 Thread Benjamin Herrenschmidt
On Wed, 2009-09-23 at 17:53 -0700, Rex Feany wrote: this is running on a MPC 875, and I'm happy to test any patches or add any debugging code if it helps. Hrm... smells like something screwy in the 8xx PTE handling. Let me have another look. Cheers, Ben.

Re: [PATCH] powerpc/mm: Fix 40x and 8xx vs. _PAGE_SPECIAL

2009-09-23 Thread Benjamin Herrenschmidt
On Wed, 2009-09-23 at 17:53 -0700, Rex Feany wrote: Thus spake Benjamin Herrenschmidt (b...@kernel.crashing.org): Bernhard, Rex, please let me know if that works for you. it doesn't work for me, it crashes differently then before though! Hrm. This is really strange... trunk+benh

Re: [PATCH] powerpc/mm: Fix 40x and 8xx vs. _PAGE_SPECIAL

2009-09-23 Thread Rex Feany
Thus spake Benjamin Herrenschmidt (b...@kernel.crashing.org): Hrm. This is really strange... Is this a problem? in pte-8xx.h you added: +#define _PAGE_SPECIAL 0x0008 /* SW entry, forced to 0 by the TLB miss */ but there is already this: #define _PAGE_EXEC 0x0008 /* software: i-cache

Re: [PATCH] powerpc/mm: Fix 40x and 8xx vs. _PAGE_SPECIAL

2009-09-23 Thread Benjamin Herrenschmidt
On Wed, 2009-09-23 at 19:38 -0700, Rex Feany wrote: Thus spake Benjamin Herrenschmidt (b...@kernel.crashing.org): Hrm. This is really strange... Is this a problem? in pte-8xx.h you added: +#define _PAGE_SPECIAL 0x0008 /* SW entry, forced to 0 by the TLB miss */ but there is already

[PATCH] powerpc/mm: Fix 40x and 8xx vs. _PAGE_SPECIAL

2009-09-22 Thread Benjamin Herrenschmidt
The test to check whether we have _PAGE_SPECIAL defined is broken, since we always define it, just not always to a meaninful value :-) That broke 8xx and 40x under some circumstances. This fixes it by adding _PAGE_SPECIAL for both of these since they had a free PTE bit, and removing the