Re: [PATCH] powerpc/numa: Fix topology_physical_package_id() on pSeries

2021-03-21 Thread David Gibson
On Tue, Mar 16, 2021 at 01:24:37PM +0100, Cédric Le Goater wrote: > The topology-id of a CPU in a pSeries machine can be queried from > sysfs but under PowerVM the value is always -1 even if NUMA nodes are > defined. This is because the topology_physical_package_id() routine is > using the

Re: [PATCH] powerpc/numa: Fix topology_physical_package_id() on pSeries

2021-03-18 Thread Daniel Henrique Barboza
On 3/18/21 4:28 AM, Cédric Le Goater wrote: Also we've been using it for several years and I don't think we should risk breaking anything by changing the value now. I guess we can leave it that way. Please read the commit log of the second patch (not tagged as a v2 ...). But we should

Re: [PATCH] powerpc/numa: Fix topology_physical_package_id() on pSeries

2021-03-18 Thread Cédric Le Goater
> Also we've been using it for several years and I don't think we should > risk breaking anything by changing the value now. I guess we can leave it that way. Please read the commit log of the second patch (not tagged as a v2 ...). But we should remove ibm,chip-id from QEMU since the property

Re: [PATCH] powerpc/numa: Fix topology_physical_package_id() on pSeries

2021-03-17 Thread Michael Ellerman
Cédric Le Goater writes: > Initial commit 15863ff3b8da ("powerpc: Make chip-id information > available to userspace") introduce a cpu_to_chip_id() routine for the > PowerNV platform using the "ibm,chip-id" property to query the chip id > of a CPU. But PAPR does not specify such a property and the

Re: [PATCH] powerpc/numa: Fix topology_physical_package_id() on pSeries

2021-03-16 Thread Cédric Le Goater
On 3/16/21 12:28 PM, Srikar Dronamraju wrote: > * C?dric Le Goater [2021-03-12 15:31:54]: > >> Initial commit 15863ff3b8da ("powerpc: Make chip-id information >> available to userspace") introduce a cpu_to_chip_id() routine for the >> PowerNV platform using the "ibm,chip-id" property to query

[PATCH] powerpc/numa: Fix topology_physical_package_id() on pSeries

2021-03-16 Thread Cédric Le Goater
The topology-id of a CPU in a pSeries machine can be queried from sysfs but under PowerVM the value is always -1 even if NUMA nodes are defined. This is because the topology_physical_package_id() routine is using the "ibm,chip-id" property which is not specified in PAPR. Under QEMU/KVM, things

Re: [PATCH] powerpc/numa: Fix topology_physical_package_id() on pSeries

2021-03-16 Thread Srikar Dronamraju
* C?dric Le Goater [2021-03-12 15:31:54]: > Initial commit 15863ff3b8da ("powerpc: Make chip-id information > available to userspace") introduce a cpu_to_chip_id() routine for the > PowerNV platform using the "ibm,chip-id" property to query the chip id > of a CPU. But PAPR does not specify such

Re: [PATCH] powerpc/numa: Fix topology_physical_package_id() on pSeries

2021-03-15 Thread Srikar Dronamraju
* C?dric Le Goater [2021-03-12 15:31:54]: > Initial commit 15863ff3b8da ("powerpc: Make chip-id information > available to userspace") introduce a cpu_to_chip_id() routine for the > PowerNV platform using the "ibm,chip-id" property to query the chip id > of a CPU. But PAPR does not specify such

Re: [PATCH] powerpc/numa: Fix topology_physical_package_id() on pSeries

2021-03-15 Thread Greg Kurz
On Fri, 12 Mar 2021 15:31:54 +0100 Cédric Le Goater wrote: > Initial commit 15863ff3b8da ("powerpc: Make chip-id information > available to userspace") introduce a cpu_to_chip_id() routine for the > PowerNV platform using the "ibm,chip-id" property to query the chip id > of a CPU. But PAPR does

Re: [PATCH] powerpc/numa: Fix topology_physical_package_id() on pSeries

2021-03-15 Thread Daniel Henrique Barboza
On 3/15/21 1:16 PM, Cédric Le Goater wrote: On 3/15/21 4:12 PM, Daniel Henrique Barboza wrote: On 3/12/21 11:31 AM, Cédric Le Goater wrote: Initial commit 15863ff3b8da ("powerpc: Make chip-id information available to userspace") introduce a cpu_to_chip_id() routine for the PowerNV

Re: [PATCH] powerpc/numa: Fix topology_physical_package_id() on pSeries

2021-03-15 Thread Cédric Le Goater
On 3/15/21 4:12 PM, Daniel Henrique Barboza wrote: > > > On 3/12/21 11:31 AM, Cédric Le Goater wrote: >> Initial commit 15863ff3b8da ("powerpc: Make chip-id information >> available to userspace") introduce a cpu_to_chip_id() routine for the >> PowerNV platform using the "ibm,chip-id" property

Re: [PATCH] powerpc/numa: Fix topology_physical_package_id() on pSeries

2021-03-15 Thread Daniel Henrique Barboza
On 3/12/21 11:31 AM, Cédric Le Goater wrote: Initial commit 15863ff3b8da ("powerpc: Make chip-id information available to userspace") introduce a cpu_to_chip_id() routine for the PowerNV platform using the "ibm,chip-id" property to query the chip id of a CPU. But PAPR does not specify such a

[PATCH] powerpc/numa: Fix topology_physical_package_id() on pSeries

2021-03-12 Thread Cédric Le Goater
Initial commit 15863ff3b8da ("powerpc: Make chip-id information available to userspace") introduce a cpu_to_chip_id() routine for the PowerNV platform using the "ibm,chip-id" property to query the chip id of a CPU. But PAPR does not specify such a property and the node id query is broken. Use