Re: [PATCH] powerpc/powernv: Read OPAL error log and export it through sysfs

2014-03-04 Thread Stewart Smith
Benjamin Herrenschmidt writes: > On Wed, 2014-03-05 at 08:56 +0530, Vasant Hegde wrote: >> On 03/05/2014 07:26 AM, Stewart Smith wrote: >> > Vasant Hegde writes: >> >>> +int64_t opal_send_ack_elog(uint64_t log_id); >> >> >> >> Stewart, >> >> >> >> Why are you creating 64bit log ID when actual ID

Re: [PATCH] powerpc/powernv: Read OPAL error log and export it through sysfs

2014-03-04 Thread Benjamin Herrenschmidt
On Wed, 2014-03-05 at 08:56 +0530, Vasant Hegde wrote: > On 03/05/2014 07:26 AM, Stewart Smith wrote: > > Vasant Hegde writes: > >>> +int64_t opal_send_ack_elog(uint64_t log_id); > >> > >> Stewart, > >> > >> Why are you creating 64bit log ID when actual ID is 32bit ? > > > > IIRC it's what OPAL g

Re: [PATCH] powerpc/powernv: Read OPAL error log and export it through sysfs

2014-03-04 Thread Vasant Hegde
On 03/05/2014 07:26 AM, Stewart Smith wrote: Vasant Hegde writes: +int64_t opal_send_ack_elog(uint64_t log_id); Stewart, Why are you creating 64bit log ID when actual ID is 32bit ? IIRC it's what OPAL gives us, even though FSP MBOX spec says 32bit. Stewart, Better ask OPAL folks to fi

Re: [PATCH] powerpc/powernv: Read OPAL error log and export it through sysfs

2014-03-04 Thread Vasant Hegde
On 03/05/2014 07:26 AM, Stewart Smith wrote: Vasant Hegde writes: +int64_t opal_send_ack_elog(uint64_t log_id); Stewart, Why are you creating 64bit log ID when actual ID is 32bit ? IIRC it's what OPAL gives us, even though FSP MBOX spec says 32bit. Stewart, Better ask OPAL folks to fi

Re: [PATCH] powerpc/powernv: Read OPAL error log and export it through sysfs

2014-03-04 Thread Stewart Smith
Vasant Hegde writes: >> +int64_t opal_send_ack_elog(uint64_t log_id); > > Stewart, > > Why are you creating 64bit log ID when actual ID is 32bit ? IIRC it's what OPAL gives us, even though FSP MBOX spec says 32bit. ___ Linuxppc-dev mailing list Linuxp

Re: [PATCH] powerpc/powernv: Read OPAL error log and export it through sysfs

2014-03-04 Thread Vasant Hegde
On 02/28/2014 06:28 AM, Stewart Smith wrote: Based on a patch by: Mahesh Salgaonkar This patch adds support to read error logs from OPAL and export them to userspace through a sysfs interface. We export each log entry as a directory in /sys/firmware/opal/elog/ Currently, OPAL will buffer up t

[PATCH] powerpc/powernv: Read OPAL error log and export it through sysfs

2014-02-27 Thread Stewart Smith
Based on a patch by: Mahesh Salgaonkar This patch adds support to read error logs from OPAL and export them to userspace through a sysfs interface. We export each log entry as a directory in /sys/firmware/opal/elog/ Currently, OPAL will buffer up to 128 error log records, we don't need to have

Re: [PATCH] powerpc/powernv: Read opal error log and export it through sysfs interface.

2014-02-25 Thread Stewart Smith
Mahesh Jagannath Salgaonkar writes: >> I think we could provide a better interface with instead having a file >> per log message appear in sysfs. We're never going to have more than 128 >> of these at any one time on the Linux side, so it's not going to bee too >> many files. > > It is not jus

Re: [PATCH] powerpc/powernv: Read opal error log and export it through sysfs interface.

2014-02-24 Thread Mahesh Jagannath Salgaonkar
On 02/21/2014 05:41 AM, Stewart Smith wrote: > Mahesh J Salgaonkar writes: > > This patch adds support to read error logs from OPAL and export them > > to userspace through sysfs interface /sys/firmware/opa/opal-elog. Hi Stewart, Thanks for the review. This code definitely needs improvement.

Re: [PATCH] powerpc/powernv: Read opal error log and export it through sysfs interface.

2014-02-20 Thread Stewart Smith
Mahesh J Salgaonkar writes: > This patch adds support to read error logs from OPAL and export them > to userspace through sysfs interface /sys/firmware/opa/opal-elog. I think we could provide a better interface with instead having a file per log message appear in sysfs. We're never going to

[PATCH] powerpc/powernv: Read opal error log and export it through sysfs interface.

2013-12-16 Thread Mahesh J Salgaonkar
From: Mahesh Salgaonkar This patch adds support to read error logs from OPAL and export them to userspace through sysfs interface /sys/firmware/opa/opal-elog. This patch buffers 128 error log records until it is consumed by userspace tool. This patch provides an sysfs interface '/sys/firmware/op