Re: [PATCH] powerpc/powernv: fix variable "c" set but not used

2019-05-23 Thread Christoph Hellwig
On Thu, May 23, 2019 at 09:26:53AM +0200, Christophe Leroy wrote: > You are not fixing the problem, you are just hiding it. > > If the result of __get_user() is unneeded, it means __get_user() is not the > good function to use. > > Should use fault_in_pages_readable() instead. Also it is not jus

Re: [PATCH] powerpc/powernv: fix variable "c" set but not used

2019-05-23 Thread Christophe Leroy
Le 23/05/2019 à 04:31, Qian Cai a écrit : The commit 58629c0dc349 ("powerpc/powernv/npu: Fault user page into the hypervisor's pagetable") introduced a variable "c" to be used in __get_user() and __get_user_nocheck() which need to stay as macros for performance reasons, and "c" is not actually

[PATCH] powerpc/powernv: fix variable "c" set but not used

2019-05-22 Thread Qian Cai
The commit 58629c0dc349 ("powerpc/powernv/npu: Fault user page into the hypervisor's pagetable") introduced a variable "c" to be used in __get_user() and __get_user_nocheck() which need to stay as macros for performance reasons, and "c" is not actually used in pnv_npu2_handle_fault(), arch/powerpc