Re: [PATCH] powerpc/pseries: Make request_ras_irqs() available to other pseries code

2010-05-19 Thread Mark Nelson
Hi Michael, Thanks for looking over these patches! On Tuesday 18 May 2010 22:40:51 Michael Ellerman wrote: On Mon, 2010-05-17 at 22:33 +1000, Mark Nelson wrote: At the moment only the RAS code uses event-sources interrupts (for EPOW events and internal errors) so request_ras_irqs() (which

Re: [PATCH] powerpc/pseries: Make request_ras_irqs() available to other pseries code

2010-05-19 Thread Michael Ellerman
On Wed, 2010-05-19 at 16:35 +1000, Mark Nelson wrote: Hi Michael, Thanks for looking over these patches! .. Existing code I know, but the error handling in here is a little lax, what's not going to work if we miss some or all of the interrupts? That's a good point. For the existing

Re: [PATCH] powerpc/pseries: Make request_ras_irqs() available to other pseries code

2010-05-19 Thread Mark Nelson
On Wednesday 19 May 2010 16:35:54 Michael Ellerman wrote: On Wed, 2010-05-19 at 16:35 +1000, Mark Nelson wrote: Hi Michael, Thanks for looking over these patches! .. Existing code I know, but the error handling in here is a little lax, what's not going to work if we miss some or

Re: [PATCH] powerpc/pseries: Make request_ras_irqs() available to other pseries code

2010-05-18 Thread Michael Ellerman
On Mon, 2010-05-17 at 22:33 +1000, Mark Nelson wrote: At the moment only the RAS code uses event-sources interrupts (for EPOW events and internal errors) so request_ras_irqs() (which actually requests the event-sources interrupts) is found in ras.c and is static. Hi Mark, Just a few niggles,

[PATCH] powerpc/pseries: Make request_ras_irqs() available to other pseries code

2010-05-17 Thread Mark Nelson
At the moment only the RAS code uses event-sources interrupts (for EPOW events and internal errors) so request_ras_irqs() (which actually requests the event-sources interrupts) is found in ras.c and is static. We want to be able to use event-sources interrupts in other pseries code, so let's