Re: [PATCH] powerpc/xmon: check before calling xive functions

2017-10-19 Thread Benjamin Herrenschmidt
On Thu, 2017-10-19 at 15:09 +0200, Cédric Le Goater wrote: > > No that's wrong. xive_enabled() is only set if Linux is using native > > xive mode but some of those xmon functions dump the emulated state. > > > > We should fix the actual cause of the crash. > > which should be in the OPAL XIVE

Re: [PATCH] powerpc/xmon: check before calling xive functions

2017-10-19 Thread Cédric Le Goater
On 10/19/2017 09:10 AM, Benjamin Herrenschmidt wrote: > On Thu, 2017-10-19 at 00:02 +1100, Michael Ellerman wrote: >> Breno Leitao writes: >> >>> Currently xmon could call XIVE functions from OPAL even if the XIVE is >>> disabled or does not exist in the system, as in POWER8

Re: [PATCH] powerpc/xmon: check before calling xive functions

2017-10-19 Thread Benjamin Herrenschmidt
On Thu, 2017-10-19 at 00:02 +1100, Michael Ellerman wrote: > Breno Leitao writes: > > > Currently xmon could call XIVE functions from OPAL even if the XIVE is > > disabled or does not exist in the system, as in POWER8 machines. This > > causes the following exception: > > >

Re: [PATCH] powerpc/xmon: check before calling xive functions

2017-10-18 Thread Michael Ellerman
Breno Leitao writes: > Currently xmon could call XIVE functions from OPAL even if the XIVE is > disabled or does not exist in the system, as in POWER8 machines. This > causes the following exception: > > 1:mon> dx > cpu 0x1: Vector: 700 (Program Check) at [c00423c93450]

[PATCH] powerpc/xmon: check before calling xive functions

2017-10-17 Thread Breno Leitao
Currently xmon could call XIVE functions from OPAL even if the XIVE is disabled or does not exist in the system, as in POWER8 machines. This causes the following exception: 1:mon> dx cpu 0x1: Vector: 700 (Program Check) at [c00423c93450] pc: c009cfa4: opal_xive_dump+0x50/0x68