Re: [PATCH] powerpc: Fix integer constant warning

2010-06-09 Thread Steve Best
On Tue, 2010-06-08 at 14:12 +0100, David Howells wrote: > Steve Best wrote: > > > -#define KERNELBASE (0xc000) > > +#define KERNELBASE (0xc000ULL) > > Is this the right fix? The code producing the warning is subtracting > 0xc000 from a 32-bit number: agree

Re: [PATCH] powerpc: Fix integer constant warning

2010-06-08 Thread David Howells
Josh Boyer wrote: > It might not matter, since Paul sent a patch to remove this file entirely. Yeah, I saw that after... David ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc: Fix integer constant warning

2010-06-08 Thread Josh Boyer
On Tue, Jun 08, 2010 at 02:12:26PM +0100, David Howells wrote: >Steve Best wrote: > >> -#define KERNELBASE (0xc000) >> +#define KERNELBASE (0xc000ULL) > >Is this the right fix? The code producing the warning is subtracting >0xc000 from a 32-bit number: It migh

Re: [PATCH] powerpc: Fix integer constant warning

2010-06-08 Thread David Howells
Steve Best wrote: > -#define KERNELBASE (0xc000) > +#define KERNELBASE (0xc000ULL) Is this the right fix? The code producing the warning is subtracting 0xc000 from a 32-bit number: naca = ntohl(*((u_int32_t*) &inbuf[0x0C])) - KERNELBASE; which seems

[PATCH] powerpc: Fix integer constant warning

2010-06-07 Thread Steve Best
Fix ppc arch/powerpc/boot/addRamDisk.c:277: warning: integer constant is too large for 'long' type Signed-off-by: Steve Best diff -purN linux.2.6.orig/arch/powerpc/boot/addRamDisk.c linux.2.6/arch/powerpc/boot/addRamDisk.c --- linux.2.6.orig/arch/powerpc/boot/addRamDisk.c 2010-06-07 15:2