Re: [PATCH] powerpc: Fix smp_wmb barrier definition use use lwsync consistently

2018-03-28 Thread Nicholas Piggin
On Wed, 28 Mar 2018 23:40:05 +1100 Michael Ellerman wrote: > Nicholas Piggin writes: > > > asm/barrier.h is not always included after asm/synch.h, which meant > > it was missing __SUBARCH_HAS_LWSYNC, so in some files smp_wmb() would > > be eieio when it

Re: [PATCH] powerpc: Fix smp_wmb barrier definition use use lwsync consistently

2018-03-28 Thread Michael Ellerman
Nicholas Piggin writes: > asm/barrier.h is not always included after asm/synch.h, which meant > it was missing __SUBARCH_HAS_LWSYNC, so in some files smp_wmb() would > be eieio when it should be lwsync. kernel/time/hrtimer.c is one case. Wow nice catch. Only broken since 2008

[PATCH] powerpc: Fix smp_wmb barrier definition use use lwsync consistently

2018-03-22 Thread Nicholas Piggin
asm/barrier.h is not always included after asm/synch.h, which meant it was missing __SUBARCH_HAS_LWSYNC, so in some files smp_wmb() would be eieio when it should be lwsync. kernel/time/hrtimer.c is one case. __SUBARCH_HAS_LWSYNC is only used in one place, so just fold it in to where it's used.