On Sun, 28 May 2023 13:16:44 +0530, mirim...@outlook.com wrote:
> The debugfs_create_dir returns ERR_PTR incase of an error and the
> correct way of checking it by using the IS_ERR inline function, and
> not the simple null comparision. This patch fixes this.
>
>
Applied to powerpc/next.
[1/1]
> Still I think this patch is an improvement so I'll plan to merge it.
Please let me know when you commit it.
Thanks
Immad.
On Tue, May 30, 2023 at 4:17 PM Michael Ellerman wrote:
> Greg KH writes:
> > On Sun, May 28, 2023 at 01:16:44PM +0530, mirim...@outlook.com wrote:
> >> From: Immad Mir
Greg KH writes:
> On Sun, May 28, 2023 at 01:16:44PM +0530, mirim...@outlook.com wrote:
>> From: Immad Mir
>>
>> The debugfs_create_dir returns ERR_PTR incase of an error and the
>> correct way of checking it by using the IS_ERR inline function, and
>> not the simple null comparision. This
> Why is this driver caring if debugfs is working or not at all? It
> should just ignore the error and keep moving forward.
I do not know. But, if the authors of the driver have decided to check for
the error, maybe use the more appropriate way?
Thanks.
Immad.
On Sun, May 28, 2023 at 1:27 PM
On Sun, May 28, 2023 at 01:16:44PM +0530, mirim...@outlook.com wrote:
> From: Immad Mir
>
> The debugfs_create_dir returns ERR_PTR incase of an error and the
> correct way of checking it by using the IS_ERR inline function, and
> not the simple null comparision. This patch fixes this.
>
>
From: Immad Mir
The debugfs_create_dir returns ERR_PTR incase of an error and the
correct way of checking it by using the IS_ERR inline function, and
not the simple null comparision. This patch fixes this.
Suggested-By: Ivan Orlov
Signed-off-by: Immad Mir
---
From: Immad Mir
The debugfs_create_dir returns ERR_PTR incase of an error and the
correct way of checking it by using the IS_ERR inline function, and
not the simple null comparision. This patch fixes this.
Suggested-By: Ivan Orlov
Signed-off-by: Immad Mir
---
