Re: [PATCH] powerpc: fix os-term usage on kernel panic

2007-12-03 Thread Linas Vepstas
On Thu, Nov 29, 2007 at 11:41:47AM +0100, Olaf Hering wrote: On Wed, Nov 28, Linas Vepstas wrote: On Wed, Nov 28, 2007 at 12:00:37PM +0100, Olaf Hering wrote: On Tue, Nov 27, Will Schmidt wrote: - if (panic_timeout) - return; This change is wrong. Booting

Re: [PATCH] powerpc: fix os-term usage on kernel panic

2007-11-30 Thread Will Schmidt
On Fri, 2007-11-30 at 16:56 +1100, Stephen Rothwell wrote: On Tue, 27 Nov 2007 18:15:59 -0600 Will Schmidt [EMAIL PROTECTED] wrote: (resending with the proper from addr this time). I'm seeing some funky behavior on power5/power6 partitions with this patch.A /sbin/reboot is now

Re: [PATCH] powerpc: fix os-term usage on kernel panic

2007-11-30 Thread Mike Strosaker
Will Schmidt wrote: From my reading of the papr, I've got the impression that there are two possibilities. First, the os-term never returns, and it's up to the service processor to do whatever it's going to do. (call home, dump, something else). Nothing we can do there. Second,

Re: [PATCH] powerpc: fix os-term usage on kernel panic

2007-11-29 Thread Olaf Hering
On Wed, Nov 28, Linas Vepstas wrote: On Wed, Nov 28, 2007 at 12:00:37PM +0100, Olaf Hering wrote: On Tue, Nov 27, Will Schmidt wrote: - if (panic_timeout) - return; This change is wrong. Booting with panic=123 really means the system has to reboot in 123

Re: [PATCH] powerpc: fix os-term usage on kernel panic

2007-11-29 Thread Will Schmidt
On Wed, 2007-11-28 at 14:18 -0600, Linas Vepstas wrote: On Tue, Nov 27, 2007 at 06:15:59PM -0600, Will Schmidt wrote: (resending with the proper from addr this time). I'm seeing some funky behavior on power5/power6 partitions with this patch.A /sbin/reboot is now behaving much

Re: [PATCH] powerpc: fix os-term usage on kernel panic

2007-11-29 Thread Stephen Rothwell
On Tue, 27 Nov 2007 18:15:59 -0600 Will Schmidt [EMAIL PROTECTED] wrote: (resending with the proper from addr this time). I'm seeing some funky behavior on power5/power6 partitions with this patch.A /sbin/reboot is now behaving much more like a /sbin/halt. Anybody else seeing

Re: [PATCH] powerpc: fix os-term usage on kernel panic

2007-11-28 Thread Linas Vepstas
On Tue, Nov 27, 2007 at 06:15:59PM -0600, Will Schmidt wrote: (resending with the proper from addr this time). I'm seeing some funky behavior on power5/power6 partitions with this patch.A /sbin/reboot is now behaving much more like a /sbin/halt. Anybody else seeing this, or is it

Re: [PATCH] powerpc: fix os-term usage on kernel panic

2007-11-28 Thread Linas Vepstas
On Wed, Nov 28, 2007 at 12:00:37PM +0100, Olaf Hering wrote: On Tue, Nov 27, Will Schmidt wrote: -void rtas_os_term(char *str) +void rtas_panic_msg(char *str) - if (panic_timeout) - return; This change is wrong. Booting with panic=123 really means the system has to

[PATCH] powerpc: fix os-term usage on kernel panic

2007-11-19 Thread Linas Vepstas
The rtas_os_term() routine was being called at the wrong time. The actual rtas call os-term will not ever return, and so calling it from the panic notifier is too early. Instead, call it from the machine_reset() call. The patch splits the rtas_os_term() routine into two: one part to capture