Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-23 Thread Segher Boessenkool
The following patch adds support for 256KB PAGE_SIZE on ppc44x- based boards. The applications to be run on the kernel with 256KB PAGE_SIZE have to be built using the modified version of binutils, where the MAXPAGESIZE definition is set to 0x4 (as opposite to standard 0x1). Have

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-23 Thread Segher Boessenkool
Requiring a modified binutils makes me a bit nervous though. As long as those binutils modifications are sent upstream, I don't see the problem? If not, this would be a blocker IMHO. Segher ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-23 Thread Paul Mackerras
Segher Boessenkool writes: If I understand you correctly, the only problem with existing binaries is that the ELF segments are aligned to 64kB, but not necessarily to 256kB. Couldn't you handle this as a special case, for example by mapping the ends of such an unaligned segment with normal

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-23 Thread Paul Mackerras
Yuri Tikhonov writes: No it isn't the violation. As stated in System V ABI. PowerPC processor supplement (on which the Linux Standard Base Core Specification for PPC32 is based): ... Virtual addresses and file offsets for the PowerPC processor family segments are congruent modulo 64

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-22 Thread Yuri Tikhonov
On Friday 19 October 2007 17:24, Kumar Gala wrote: On Oct 18, 2007, at 6:21 PM, Paul Mackerras wrote: Yuri Tikhonov writes: The following patch adds support for 256KB PAGE_SIZE on ppc44x- based boards. The applications to be run on the kernel with 256KB PAGE_SIZE have to be

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-19 Thread Wolfgang Denk
Dear Josh, in message [EMAIL PROTECTED] you wrote: The following patch adds support for 256KB PAGE_SIZE on ppc44x-based boards. The applications to be run on the kernel with 256KB PAGE_SIZE have to be built using the modified version of binutils, where the MAXPAGESIZE definition

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-19 Thread Kumar Gala
On Oct 19, 2007, at 10:37 AM, Yuri Tikhonov wrote: On Friday 19 October 2007 03:21, Paul Mackerras wrote: Have you measured the performance using a 64kB page size? If so, how does it compare with the 256kB page size? I measured the performance of the sequential full-stripe write

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-19 Thread Kumar Gala
On Oct 18, 2007, at 6:21 PM, Paul Mackerras wrote: Yuri Tikhonov writes: The following patch adds support for 256KB PAGE_SIZE on ppc44x- based boards. The applications to be run on the kernel with 256KB PAGE_SIZE have to be built using the modified version of binutils, where the

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-19 Thread Yuri Tikhonov
On Friday 19 October 2007 03:21, Paul Mackerras wrote: Have you measured the performance using a 64kB page size? If so, how does it compare with the 256kB page size? I measured the performance of the sequential full-stripe write operations to a RAID-5 array (P values below are in MB per

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-19 Thread Yuri Tikhonov
On Friday 19 October 2007 19:48, Kumar Gala wrote: PAGE_SIZE = 4K: P = 66 MBps; PAGE_SIZE = 16K: P = 145 MBps; PAGE_SIZE = 64K: P = 196 MBps; PAGE_SIZE = 256K: P = 217 MBps. Is this all in kernel space? or is there a user space aspect to the benchmark? The

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-18 Thread Josh Boyer
On Thu, 2007-10-18 at 11:08 +0400, Yuri Tikhonov wrote: Hello, The following patch adds support for 256KB PAGE_SIZE on ppc44x-based boards. The applications to be run on the kernel with 256KB PAGE_SIZE have to be built using the modified version of binutils, where the MAXPAGESIZE

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-18 Thread Yuri Tikhonov
It has turned out that my mailer had corrupted my previous message (thanks Wolfgang Denk for pointing this). So if you'd like to apply the patch without the conflicts please use the version of the patch in this mail. The following patch adds support for 256KB PAGE_SIZE on ppc44x-based boards.

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-18 Thread Benjamin Herrenschmidt
On Thu, 2007-10-18 at 05:44 -0500, Josh Boyer wrote: On Thu, 2007-10-18 at 11:08 +0400, Yuri Tikhonov wrote: Hello, The following patch adds support for 256KB PAGE_SIZE on ppc44x-based boards. The applications to be run on the kernel with 256KB PAGE_SIZE have to be built using

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-18 Thread Benjamin Herrenschmidt
On Thu, 2007-10-18 at 15:00 +0400, Yuri Tikhonov wrote: It has turned out that my mailer had corrupted my previous message (thanks Wolfgang Denk for pointing this). So if you'd like to apply the patch without the conflicts please use the version of the patch in this mail. The following

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-18 Thread Josh Boyer
On Thu, 18 Oct 2007 21:45:14 +1000 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Thu, 2007-10-18 at 05:44 -0500, Josh Boyer wrote: On Thu, 2007-10-18 at 11:08 +0400, Yuri Tikhonov wrote: Hello, The following patch adds support for 256KB PAGE_SIZE on ppc44x-based boards.

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-18 Thread Benjamin Herrenschmidt
On Thu, 2007-10-18 at 07:01 -0500, Josh Boyer wrote: On Thu, 18 Oct 2007 21:45:14 +1000 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Thu, 2007-10-18 at 05:44 -0500, Josh Boyer wrote: On Thu, 2007-10-18 at 11:08 +0400, Yuri Tikhonov wrote: Hello, The following

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-18 Thread Yuri Tikhonov
On Thursday 18 October 2007 14:44, you wrote: Sorry, this is against arch/ppc which is bug fix only. New features should be done against arch/powerpc. Understood. The situation here is that the boards, which required these modifications, have no support in the arch/powerpc branch. So this

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-18 Thread Yuri Tikhonov
On Thursday 18 October 2007 15:47, Benjamin Herrenschmidt wrote: Signed-off-by: Pavel Kolesnikov [EMAIL PROTECTED] Acked-by: Yuri Tikhonov [EMAIL PROTECTED] Small nit... You are posting the patch, thus you should be signing off, not ack'ing. Ack'ing means you agree with the patch

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-18 Thread Yuri Tikhonov
On Thursday 18 October 2007 16:12, Benjamin Herrenschmidt wrote: I always reserve the right to change my mind. If something makes sense and the code is decent enough then it might very well be acceptable. Requiring a modified binutils makes me a bit nervous though. From a kernel point

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-18 Thread Yuri Tikhonov
On Thursday 18 October 2007 17:25, Josh Boyer wrote: Understood. The situation here is that the boards, which required these modifications, have no support in the arch/powerpc branch. So this is why we made this in arch/ppc. Bit of a dilemma then. What board exactly? These are the

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-18 Thread Josh Boyer
On Thu, 18 Oct 2007 17:18:00 +0400 Yuri Tikhonov [EMAIL PROTECTED] wrote: On Thursday 18 October 2007 14:44, you wrote: Sorry, this is against arch/ppc which is bug fix only. New features should be done against arch/powerpc. Understood. The situation here is that the boards, which

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-18 Thread Josh Boyer
On Thu, 18 Oct 2007 17:30:17 +0400 Yuri Tikhonov [EMAIL PROTECTED] wrote: On Thursday 18 October 2007 17:25, Josh Boyer wrote: Understood. The situation here is that the boards, which required these modifications, have no support in the arch/powerpc branch. So this is why we made this

Re: [PATCH] ppc44x: support for 256K PAGE_SIZE

2007-10-18 Thread Paul Mackerras
Yuri Tikhonov writes: The following patch adds support for 256KB PAGE_SIZE on ppc44x-based boards. The applications to be run on the kernel with 256KB PAGE_SIZE have to be built using the modified version of binutils, where the MAXPAGESIZE definition is set to 0x4 (as opposite to