Re: [PATCH] properly reserve in bootmem the lmb reserved regions that cross numa nodes

2008-10-06 Thread Jon Tollefson
Kumar Gala wrote: > > On Oct 6, 2008, at 10:42 AM, Jon Tollefson wrote: > >> Kumar Gala wrote: >>> Out of interest how to do you guys represent NUMA regions of memory in >>> the device tree? >>> >>> - k >> Looking at the source code in numa.c I see at the start of >> do_init_bootmem() that parse_nu

Re: [PATCH] properly reserve in bootmem the lmb reserved regions that cross numa nodes

2008-10-06 Thread Kumar Gala
On Oct 6, 2008, at 10:42 AM, Jon Tollefson wrote: Kumar Gala wrote: Out of interest how to do you guys represent NUMA regions of memory in the device tree? - k Looking at the source code in numa.c I see at the start of do_init_bootmem() that parse_numa_properties() is called. It appears

Re: [PATCH] properly reserve in bootmem the lmb reserved regions that cross numa nodes

2008-10-06 Thread Jon Tollefson
Kumar Gala wrote: > Out of interest how to do you guys represent NUMA regions of memory in > the device tree? > > - k Looking at the source code in numa.c I see at the start of do_init_bootmem() that parse_numa_properties() is called. It appears to be looking at memory nodes and getting the node i

Re: [PATCH] properly reserve in bootmem the lmb reserved regions that cross numa nodes

2008-10-02 Thread Jon Tollefson
Adam Litke wrote: > This seems like the right approach to me. I have pointed out a few > stylistic issues below. > Thanks. I'll make those changes. I assume by __mminit you meant __meminit Jon > On Tue, 2008-09-30 at 09:53 -0500, Jon Tollefson wrote: > > >> +/* Mark reserved regions

Re: [PATCH] properly reserve in bootmem the lmb reserved regions that cross numa nodes

2008-10-01 Thread Kumar Gala
Out of interest how to do you guys represent NUMA regions of memory in the device tree? - k ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] properly reserve in bootmem the lmb reserved regions that cross numa nodes

2008-09-30 Thread Adam Litke
This seems like the right approach to me. I have pointed out a few stylistic issues below. On Tue, 2008-09-30 at 09:53 -0500, Jon Tollefson wrote: > + /* Mark reserved regions */ > + for (i = 0; i < lmb.reserved.cnt; i++) { > + unsigned long physbase = lmb.reserved.region[i].

[PATCH] properly reserve in bootmem the lmb reserved regions that cross numa nodes

2008-09-30 Thread Jon Tollefson
If there are multiple reserved memory blocks via lmb_reserve() that are contiguous addresses and on different numa nodes we are losing track of which address ranges to reserve in bootmem on which node. I discovered this when I only recently got to try 16GB huge pages on a system with more then