Re: [PATCH] pwm: Add missing "CONFIG_" prefix

2020-06-04 Thread Joe Perches
On Thu, 2020-06-04 at 14:52 -0700, Kees Cook wrote: > On Wed, Jun 03, 2020 at 04:04:31PM -0700, Joe Perches wrote: > > On Wed, 2020-06-03 at 15:40 -0700, Kees Cook wrote: > > > The IS_ENABLED() use was missing the CONFIG_ prefix which would have > > > lead to skipping this code. > > > > > >

Re: [PATCH] pwm: Add missing "CONFIG_" prefix

2020-06-04 Thread Kees Cook
On Wed, Jun 03, 2020 at 04:04:31PM -0700, Joe Perches wrote: > On Wed, 2020-06-03 at 15:40 -0700, Kees Cook wrote: > > The IS_ENABLED() use was missing the CONFIG_ prefix which would have > > lead to skipping this code. > > > > Fixes: 3ad1f3a33286 ("pwm: Implement some checks for lowlevel

Re: [PATCH] pwm: Add missing "CONFIG_" prefix

2020-06-03 Thread Kees Cook
On Wed, Jun 03, 2020 at 04:04:31PM -0700, Joe Perches wrote: > more odd uses (mostly in comments) > > $ git grep -P -oh '\bIS_ENABLED\s*\(\s*\w+\s*\)'| \ > sed -r 's/\s+//g'| \ > grep -v '(CONFIG_' | \ > sort | uniq -c | sort -rn I think a missed a bunch because my grep was messy. :) This

Re: [PATCH] pwm: Add missing "CONFIG_" prefix

2020-06-03 Thread Joe Perches
On Wed, 2020-06-03 at 15:40 -0700, Kees Cook wrote: > The IS_ENABLED() use was missing the CONFIG_ prefix which would have > lead to skipping this code. > > Fixes: 3ad1f3a33286 ("pwm: Implement some checks for lowlevel drivers") > Signed-off-by: Kees Cook > --- > drivers/pwm/core.c | 2 +- > 1