Re: [PATCH] rio: warn_unused_result warnings fix

2009-04-28 Thread Li Yang
On Tue, Apr 28, 2009 at 6:51 PM, Michael Ellerman mich...@ellerman.id.au wrote: On Tue, 2009-04-28 at 18:15 +0800, Li Yang wrote: warning: ignoring return value of 'device_add', declared with attribute warn_unused_result warning: ignoring return value of 'sysfs_create_bin_file', declared with

Re: [PATCH] rio: warn_unused_result warnings fix

2009-04-28 Thread David Miller
From: Li Yang le...@freescale.com Date: Tue, 28 Apr 2009 19:08:13 +0800 IMHO, when device_add() fails the system is quite broken. So the value is very limited for it to fail cleanly, which need some effort to implement. I can add it if you insist. I disagree. For the cases where

[PATCH] rio: warn_unused_result warnings fix

2009-04-28 Thread Li Yang
warning: ignoring return value of 'device_add', declared with attribute warn_unused_result warning: ignoring return value of 'sysfs_create_bin_file', declared with attribute warn_unused_result Signed-off-by: Li Yang le...@freescale.com --- drivers/rapidio/rio-scan.c |5 -