Re: [PATCH] sched: Use WARN_ON

2021-07-01 Thread Arnd Bergmann
On Thu, Jul 1, 2021 at 2:57 PM Christophe Leroy wrote: > Le 01/07/2021 à 14:50, Jason Wang a écrit : > > The BUG_ON macro simplifies the if condition followed by BUG, but it > > will lead to the kernel crashing. Therefore, we can try using WARN_ON > > instead of if condition followed by BUG. > >

Re: [PATCH] sched: Use WARN_ON

2021-07-01 Thread Christophe Leroy
Le 01/07/2021 à 14:50, Jason Wang a écrit : The BUG_ON macro simplifies the if condition followed by BUG, but it will lead to the kernel crashing. Therefore, we can try using WARN_ON instead of if condition followed by BUG. But are you sure it is ok to continue if spu_acquire(ctx) returned

[PATCH] sched: Use WARN_ON

2021-07-01 Thread Jason Wang
The BUG_ON macro simplifies the if condition followed by BUG, but it will lead to the kernel crashing. Therefore, we can try using WARN_ON instead of if condition followed by BUG. Signed-off-by: Jason Wang --- arch/powerpc/platforms/cell/spufs/sched.c | 4 ++-- 1 file changed, 2 insertions(+),