Re: [PATCH] scsi/ipr: Fix runaway IRQs when falling back from MSI to LSI

2016-11-30 Thread Martin K. Petersen
> "Brian" == Brian King writes: Brian> Looks good. Thanks! Here is an updated version that should apply Brian> cleanly on top of scsi-next. Applied to 4.10/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi/ipr: Fix runaway IRQs when falling back from MSI to LSI

2016-11-30 Thread Brian King
Looks good. Thanks! Here is an updated version that should apply cleanly on top of scsi-next. 8< From: Benjamin Herrenschmidt LSIs must be ack'ed with an MMIO otherwise they remain asserted forever. This is controlled by the "clear_isr" flag. While we set that flag

Re: [PATCH] scsi/ipr: Fix runaway IRQs when falling back from MSI to LSI

2016-11-29 Thread Martin K. Petersen
> "Benjamin" == Benjamin Herrenschmidt writes: Benjamin> LSIs must be ack'ed with an MMIO otherwise they remain Benjamin> asserted forever. This is controlled by the "clear_isr" flag. Benjamin> While we set that flag properly when deciding initially Benjamin>

[PATCH] scsi/ipr: Fix runaway IRQs when falling back from MSI to LSI

2016-11-23 Thread Benjamin Herrenschmidt
LSIs must be ack'ed with an MMIO otherwise they remain asserted forever. This is controlled by the "clear_isr" flag. While we set that flag properly when deciding initially whether to use LSIs or MSIs, we fail to set it if we first chose MSIs, the test fails, then fallback to LSIs.