Re: [PATCH / RFC] net: fix locking in ibm_newemac

2008-08-14 Thread Sebastian Siewior
* Benjamin Herrenschmidt | 2008-08-14 13:45:54 [+1000]: The fix is to defer phy init until netdevice is registered / initialized. I think it's better instead to take the dev_mc_add() statement out of emac_configure(). I looked yesterday into that code and I saw that dev_mc_add() was called by

[PATCH / RFC] net: fix locking in ibm_newemac

2008-08-13 Thread Sebastian Siewior
|PPC 4xx OCP EMAC driver, version 3.54 |MAL v2 /plb/mcmal, 2 TX channels, 2 RX channels |RGMII /plb/opb/[EMAIL PROTECTED] initialized with MDIO support |/plb/opb/[EMAIL PROTECTED]: input 0 in RGMII mode |BUG: spinlock bad magic on CPU#0, swapper/1 | lock: cf81632c, .magic: , .owner:

Re: [PATCH / RFC] net: fix locking in ibm_newemac

2008-08-13 Thread Benjamin Herrenschmidt
On Wed, 2008-08-13 at 20:29 +0200, Sebastian Siewior wrote: |PPC 4xx OCP EMAC driver, version 3.54 |MAL v2 /plb/mcmal, 2 TX channels, 2 RX channels |RGMII /plb/opb/[EMAIL PROTECTED] initialized with MDIO support |/plb/opb/[EMAIL PROTECTED]: input 0 in RGMII mode |BUG: spinlock bad magic on