Re: [PATCH -next] powerpc/85xx: Add support for X-ES MPC85xx boards

2009-06-10 Thread Kumar Gala
On Jun 10, 2009, at 4:46 PM, Nate Case wrote: Hi Kumar, Thanks for the feedback. Response below: + + root = of_find_node_by_path(/); + if (root == NULL) + return; + + model = of_get_property(root, model, NULL); + if (strncasecmp(model, xes,,

Re: [PATCH -next] powerpc/85xx: Add support for X-ES MPC85xx boards

2009-06-09 Thread Nate Case
On Mon, 2009-06-08 at 17:52 -0500, Kumar Gala wrote: +static void xes_mpc85xx_configure_l1(void) +{ [snip] I'd prefer we move this into __setup_cpu_e500v1/__setup_cpu_e500v2 so its done for all processors regardless of platform. How does something like this look? Let me know and I can

Re: [PATCH -next] powerpc/85xx: Add support for X-ES MPC85xx boards

2009-06-09 Thread Kumar Gala
On Jun 9, 2009, at 1:53 PM, Nate Case wrote: On Mon, 2009-06-08 at 17:52 -0500, Kumar Gala wrote: +static void xes_mpc85xx_configure_l1(void) +{ [snip] I'd prefer we move this into __setup_cpu_e500v1/__setup_cpu_e500v2 so its done for all processors regardless of platform. How does

Re: [PATCH -next] powerpc/85xx: Add support for X-ES MPC85xx boards

2009-06-08 Thread Kumar Gala
On Jun 8, 2009, at 5:13 PM, Nate Case wrote: +static void xes_mpc85xx_configure_l1(void) +{ + uint spr; + asm volatile(msync; isync); + spr = mfspr(SPRN_L1CSR1); + asm volatile(msync; isync); + /* Enable instruction cache */ + mtspr(SPRN_L1CSR1, spr |

Re: [PATCH -next] powerpc/85xx: Add support for X-ES MPC85xx boards

2009-06-08 Thread Kumar Gala
diff --git a/arch/powerpc/platforms/85xx/xes_mpc85xx.c b/arch/ powerpc/platforms/85xx/xes_mpc85xx.c new file mode 100644 index 000..c1b55b8 --- /dev/null +++ b/arch/powerpc/platforms/85xx/xes_mpc85xx.c @@ -0,0 +1,332 @@ +/* + * Copyright (C) 2009 Extreme Engineering Solutions, Inc. + * + *