Re: [PATCH 0/2] powerpc/xive: fix CPU hot unplug

2017-10-05 Thread Cédric Le Goater
>>> I haven't yet because I fail to understand why the decrementer is not >>> interrupting the dying CPU under xics as it is the case under XIVE. >> >> Oh.. ok. This sounds very similar to the problem Nikunj hit under TCG >> with decrementer interrupts waking up a supposedly dead CPU. He had a >

Re: [PATCH 0/2] powerpc/xive: fix CPU hot unplug

2017-10-04 Thread Nikunj A Dadhania
David Gibson writes: > On Tue, Oct 03, 2017 at 08:24:07AM +0200, Cédric Le Goater wrote: >> On 10/03/2017 05:36 AM, David Gibson wrote: >> > On Mon, Oct 02, 2017 at 06:27:20PM +0200, Cédric Le Goater wrote: >> >> On 09/23/2017 10:26 AM, Cédric Le Goater wrote: >> >>> Hi, >> >>> >> >>> Here are a

Re: [PATCH 0/2] powerpc/xive: fix CPU hot unplug

2017-10-04 Thread Cédric Le Goater
On 10/03/2017 08:58 AM, David Gibson wrote: > On Tue, Oct 03, 2017 at 08:24:07AM +0200, Cédric Le Goater wrote: >> On 10/03/2017 05:36 AM, David Gibson wrote: >>> On Mon, Oct 02, 2017 at 06:27:20PM +0200, Cédric Le Goater wrote: On 09/23/2017 10:26 AM, Cédric Le Goater wrote: > Hi, > >

Re: [PATCH 0/2] powerpc/xive: fix CPU hot unplug

2017-10-03 Thread Cédric Le Goater
Hello Michael, On 10/03/2017 01:23 PM, Michael Ellerman wrote: > Cédric Le Goater writes: > >> On 09/23/2017 10:26 AM, Cédric Le Goater wrote: >>> Hi, >>> >>> Here are a couple of small fixes to support CPU hot unplug. There are >>> still some issues to be investigated as, in some occasions, aft

Re: [PATCH 0/2] powerpc/xive: fix CPU hot unplug

2017-10-03 Thread Michael Ellerman
Cédric Le Goater writes: > On 09/23/2017 10:26 AM, Cédric Le Goater wrote: >> Hi, >> >> Here are a couple of small fixes to support CPU hot unplug. There are >> still some issues to be investigated as, in some occasions, after a >> couple of plug and unplug, the cpu which was removed receives a

Re: [PATCH 0/2] powerpc/xive: fix CPU hot unplug

2017-10-03 Thread Benjamin Herrenschmidt
On Tue, 2017-10-03 at 17:58 +1100, David Gibson wrote: > > Ok.. why do you think this isn't of use? I'm pretty sure this is > necessary for the TCG case, since MSR is checked in cpu_has_work(), > which could otherwise wake up the "dead" cpu. Ony if it's not in a PM state, in that case we check t

Re: [PATCH 0/2] powerpc/xive: fix CPU hot unplug

2017-10-02 Thread David Gibson
On Tue, Oct 03, 2017 at 08:24:07AM +0200, Cédric Le Goater wrote: > On 10/03/2017 05:36 AM, David Gibson wrote: > > On Mon, Oct 02, 2017 at 06:27:20PM +0200, Cédric Le Goater wrote: > >> On 09/23/2017 10:26 AM, Cédric Le Goater wrote: > >>> Hi, > >>> > >>> Here are a couple of small fixes to suppor

Re: [PATCH 0/2] powerpc/xive: fix CPU hot unplug

2017-10-02 Thread Cédric Le Goater
On 10/03/2017 05:36 AM, David Gibson wrote: > On Mon, Oct 02, 2017 at 06:27:20PM +0200, Cédric Le Goater wrote: >> On 09/23/2017 10:26 AM, Cédric Le Goater wrote: >>> Hi, >>> >>> Here are a couple of small fixes to support CPU hot unplug. There are >>> still some issues to be investigated as, in so

Re: [PATCH 0/2] powerpc/xive: fix CPU hot unplug

2017-10-02 Thread David Gibson
On Mon, Oct 02, 2017 at 06:27:20PM +0200, Cédric Le Goater wrote: > On 09/23/2017 10:26 AM, Cédric Le Goater wrote: > > Hi, > > > > Here are a couple of small fixes to support CPU hot unplug. There are > > still some issues to be investigated as, in some occasions, after a > > couple of plug and u

Re: [PATCH 0/2] powerpc/xive: fix CPU hot unplug

2017-10-02 Thread Cédric Le Goater
On 10/02/2017 06:52 PM, Benjamin Herrenschmidt wrote: > On Mon, 2017-10-02 at 18:27 +0200, Cédric Le Goater wrote: >> On 09/23/2017 10:26 AM, Cédric Le Goater wrote: >>> Hi, >>> >>> Here are a couple of small fixes to support CPU hot unplug. There are >>> still some issues to be investigated as, in

Re: [PATCH 0/2] powerpc/xive: fix CPU hot unplug

2017-10-02 Thread Benjamin Herrenschmidt
On Mon, 2017-10-02 at 18:27 +0200, Cédric Le Goater wrote: > On 09/23/2017 10:26 AM, Cédric Le Goater wrote: > > Hi, > > > > Here are a couple of small fixes to support CPU hot unplug. There are > > still some issues to be investigated as, in some occasions, after a > > couple of plug and unplug,

Re: [PATCH 0/2] powerpc/xive: fix CPU hot unplug

2017-10-02 Thread Cédric Le Goater
On 09/23/2017 10:26 AM, Cédric Le Goater wrote: > Hi, > > Here are a couple of small fixes to support CPU hot unplug. There are > still some issues to be investigated as, in some occasions, after a > couple of plug and unplug, the cpu which was removed receives a 'lost' > interrupt. This showed to

[PATCH 0/2] powerpc/xive: fix CPU hot unplug

2017-09-23 Thread Cédric Le Goater
Hi, Here are a couple of small fixes to support CPU hot unplug. There are still some issues to be investigated as, in some occasions, after a couple of plug and unplug, the cpu which was removed receives a 'lost' interrupt. This showed to be the decrementer under QEMU. Nevertheless, these patches