Re: [PATCH 02/10] fs: don't allow splice read/write without explicit ops

2020-10-27 Thread David Howells
Christoph Hellwig wrote: > > That said, for afs at least, the fix seems to be just this: > > And that is the correct fix, I was about to send it to you. Thanks. David

Re: [PATCH 02/10] fs: don't allow splice read/write without explicit ops

2020-10-27 Thread Christoph Hellwig
On Tue, Oct 27, 2020 at 09:51:34AM +, David Howells wrote: > David Howells wrote: > > > > default_file_splice_write is the last piece of generic code that uses > > > set_fs to make the uaccess routines operate on kernel pointers. It > > > implements a "fallback loop" for splicing from files

Re: [PATCH 02/10] fs: don't allow splice read/write without explicit ops

2020-10-27 Thread David Howells
David Howells wrote: > > default_file_splice_write is the last piece of generic code that uses > > set_fs to make the uaccess routines operate on kernel pointers. It > > implements a "fallback loop" for splicing from files that do not actually > > provide a proper splice_read method. The usual

Re: [PATCH 02/10] fs: don't allow splice read/write without explicit ops

2020-10-27 Thread David Howells
Christoph Hellwig wrote: > default_file_splice_write is the last piece of generic code that uses > set_fs to make the uaccess routines operate on kernel pointers. It > implements a "fallback loop" for splicing from files that do not actually > provide a proper splice_read method. The usual

[PATCH 02/10] fs: don't allow splice read/write without explicit ops

2020-08-27 Thread Christoph Hellwig
default_file_splice_write is the last piece of generic code that uses set_fs to make the uaccess routines operate on kernel pointers. It implements a "fallback loop" for splicing from files that do not actually provide a proper splice_read method. The usual file systems and other high bandwith