Re: [PATCH 02/11] powerpc/nvram: More flexible nvram_create_partition()

2010-08-02 Thread Benjamin Herrenschmidt
On Mon, 2010-08-02 at 10:55 +1000, Benjamin Herrenschmidt wrote: Replace nvram_create_os_partition() with a variant that takes the partition name, signature and size as arguments. Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org --- arch/powerpc/kernel/nvram_64.c |

[PATCH 02/11] powerpc/nvram: More flexible nvram_create_partition()

2010-08-01 Thread Benjamin Herrenschmidt
Replace nvram_create_os_partition() with a variant that takes the partition name, signature and size as arguments. Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org --- arch/powerpc/kernel/nvram_64.c | 46 +++

Re: [PATCH 02/11] powerpc/nvram: More flexible nvram_create_partition()

2010-08-01 Thread Michael Ellerman
On Mon, 2010-08-02 at 10:55 +1000, Benjamin Herrenschmidt wrote: Replace nvram_create_os_partition() with a variant that takes the partition name, signature and size as arguments. Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org --- arch/powerpc/kernel/nvram_64.c |

Re: [PATCH 02/11] powerpc/nvram: More flexible nvram_create_partition()

2010-08-01 Thread Benjamin Herrenschmidt
On Mon, 2010-08-02 at 13:43 +1000, Michael Ellerman wrote: /* try creating a partition with the free space we have */ - rc = nvram_create_partition(ppc64,linux, ); That looks odd? Trailing comma. Yeah, that and... diff --git a/arch/powerpc/platforms/pseries/nvram.c