Re: [PATCH 02/20] ASoC: efika-audio-fabric.c: Switch to SPDX identifier

2019-04-05 Thread Fabio Estevam
On Fri, Apr 5, 2019 at 10:24 AM Mukesh Ojha wrote: > you mean all lines to start with //, does not it look to noisy to eyes ? Mark Brown's recommendation is to use // in all the initial block lines instead of only in the SPDX one.

Re: [PATCH 02/20] ASoC: efika-audio-fabric.c: Switch to SPDX identifier

2019-04-05 Thread Mukesh Ojha
On 4/5/2019 6:20 PM, Fabio Estevam wrote: On Fri, Apr 5, 2019 at 9:47 AM Mukesh Ojha wrote: Don't change entire thing with //. only above line with the license is enough. Please apply this rule every patch of yours. Not really. This is the style preferred in this subsystem. you mean

Re: [PATCH 02/20] ASoC: efika-audio-fabric.c: Switch to SPDX identifier

2019-04-05 Thread Fabio Estevam
On Fri, Apr 5, 2019 at 9:47 AM Mukesh Ojha wrote: > Don't change entire thing with //. only above line with the license is > enough. > > Please apply this rule every patch of yours. Not really. This is the style preferred in this subsystem.

Re: [PATCH 02/20] ASoC: efika-audio-fabric.c: Switch to SPDX identifier

2019-04-05 Thread Mukesh Ojha
On 4/5/2019 5:19 PM, Andra Danciu wrote: Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/efika-audio-fabric.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git

[PATCH 02/20] ASoC: efika-audio-fabric.c: Switch to SPDX identifier

2019-04-05 Thread Andra Danciu
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Andra Danciu --- sound/soc/fsl/efika-audio-fabric.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/sound/soc/fsl/efika-audio-fabric.c