Re: [PATCH 04/14] cxlflash: Avoid command room violation

2016-11-17 Thread Uma Krishnan
Thanks for catching this Matt. Looking into this. Will send out a V2. On 11/17/2016 1:36 PM, Matthew R. Ochs wrote: Hi Uma, I do see a potential hang issue with this patch. See my comments below. -matt On Nov 15, 2016, at 5:14 PM, Uma Krishnan wrote: During

Re: [PATCH 04/14] cxlflash: Avoid command room violation

2016-11-17 Thread Matthew R. Ochs
Hi Uma, I do see a potential hang issue with this patch. See my comments below. -matt > On Nov 15, 2016, at 5:14 PM, Uma Krishnan wrote: > > During test, a command room violation interrupt is occasionally seen > for the master context when the CXL flash devices

[PATCH 04/14] cxlflash: Avoid command room violation

2016-11-15 Thread Uma Krishnan
During test, a command room violation interrupt is occasionally seen for the master context when the CXL flash devices are stressed. After studying the code, there could be gaps in the way command room value is being cached in cxlflash. When the cached command room is zero the thread attempting