Re: [PATCH 04/15] swiotlb: remove unnecessary swiotlb_bus_to_virt

2009-07-15 Thread Benjamin Herrenschmidt
On Mon, 2009-07-13 at 21:17 -0500, Becky Bruce wrote: > > phys_to_virt (also, virt_to_phys) is invalid for highmem addresses on > ppc. I would be surprised if x86 was any different here. Most of our highmem implementation comes straight from x86 :-) Cheers, Ben.

Re: [PATCH 04/15] swiotlb: remove unnecessary swiotlb_bus_to_virt

2009-07-13 Thread FUJITA Tomonori
On Mon, 13 Jul 2009 21:17:21 -0500 Becky Bruce wrote: > > On Jul 9, 2009, at 8:04 PM, FUJITA Tomonori wrote: > > > swiotlb_bus_to_virt is unncessary; we can use swiotlb_bus_to_phys and > > phys_to_virt instead. > > phys_to_virt (also, virt_to_phys) is invalid for highmem addresses on > ppc.

Re: [PATCH 04/15] swiotlb: remove unnecessary swiotlb_bus_to_virt

2009-07-13 Thread Becky Bruce
On Jul 9, 2009, at 8:04 PM, FUJITA Tomonori wrote: swiotlb_bus_to_virt is unncessary; we can use swiotlb_bus_to_phys and phys_to_virt instead. phys_to_virt (also, virt_to_phys) is invalid for highmem addresses on ppc. In most of the uses in this file, it doesn't matter, as the iotlb buff

[PATCH 04/15] swiotlb: remove unnecessary swiotlb_bus_to_virt

2009-07-09 Thread FUJITA Tomonori
swiotlb_bus_to_virt is unncessary; we can use swiotlb_bus_to_phys and phys_to_virt instead. Signed-off-by: FUJITA Tomonori --- arch/powerpc/kernel/dma-swiotlb.c | 10 -- lib/swiotlb.c | 34 -- 2 files changed, 16 insertions(+), 28 d