Re: [PATCH 06/15] 8xx: Always pin kernel instruction TLB

2011-06-15 Thread Joakim Tjernlund
Joakim Tjernlund/Transmode wrote on 2011/06/14 20:00:09: From: Joakim Tjernlund/Transmode Dan Malek ppc6...@digitaldans.com wrote on 2011/06/14 18:06:45: Hi Joakim. On Jun 14, 2011, at 6:54 AM, Joakim Tjernlund wrote: Various kernel asm modifies SRR0/SRR1 just before executing

Re: [PATCH 06/15] 8xx: Always pin kernel instruction TLB

2011-06-15 Thread Joakim Tjernlund
Dan Malek ppc6...@digitaldans.com wrote on 2011/06/14 20:11:18: Hi Joakim. On Jun 14, 2011, at 11:00 AM, Joakim Tjernlund wrote: I don't have a mpc850, do you? I have to say I do :-) Probably but that is another matter. You could continue with that if you like but I am stopping here

[PATCH 06/15] 8xx: Always pin kernel instruction TLB

2011-06-14 Thread Joakim Tjernlund
Various kernel asm modifies SRR0/SRR1 just before executing a rfi. If such code crosses a page boundary you risk a TLB miss which will clobber SRR0/SRR1. Avoid this by always pinning kernel instruction TLB space. Signed-off-by: Joakim Tjernlund joakim.tjernl...@transmode.se ---

Re: [PATCH 06/15] 8xx: Always pin kernel instruction TLB

2011-06-14 Thread Dan Malek
Hi Joakim. On Jun 14, 2011, at 6:54 AM, Joakim Tjernlund wrote: Various kernel asm modifies SRR0/SRR1 just before executing a rfi. . I'm going to argue we can easily visually inspect for this since the code is static with just a couple of RFIs in these exception handlers. Some 8xx

Re: [PATCH 06/15] 8xx: Always pin kernel instruction TLB

2011-06-14 Thread Joakim Tjernlund
Dan Malek ppc6...@digitaldans.com wrote on 2011/06/14 18:06:45: Hi Joakim. On Jun 14, 2011, at 6:54 AM, Joakim Tjernlund wrote: Various kernel asm modifies SRR0/SRR1 just before executing a rfi. . I'm going to argue we can easily visually inspect for this since the code is static

Re: [PATCH 06/15] 8xx: Always pin kernel instruction TLB

2011-06-14 Thread Dan Malek
Hi Joakim. On Jun 14, 2011, at 11:00 AM, Joakim Tjernlund wrote: I don't have a mpc850, do you? I have to say I do :-) Probably but that is another matter. You could continue with that if you like but I am stopping here ATM. Oh, come on... I've been thinking about this for years,

Re: [PATCH 06/15] 8xx: Always pin kernel instruction TLB

2011-06-14 Thread Joakim Tjernlund
Dan Malek ppc6...@digitaldans.com wrote on 2011/06/14 20:11:18: Hi Joakim. On Jun 14, 2011, at 11:00 AM, Joakim Tjernlund wrote: I don't have a mpc850, do you? I have to say I do :-) Good, you get to beat the crap out of it then :) Probably but that is another matter. You could