Re: [PATCH 07/10] powerpc/mm/slice: Switch to 3-operand slice bitops helpers

2018-03-06 Thread Nicholas Piggin
On Tue, 6 Mar 2018 15:44:46 +0100 Christophe LEROY wrote: > Le 06/03/2018 à 14:25, Nicholas Piggin a écrit : > > This converts the slice_mask bit operation helpers to be the usual > > 3-operand kind, which is clearer to work with. > > What's the real benefit of doing

Re: [PATCH 07/10] powerpc/mm/slice: Switch to 3-operand slice bitops helpers

2018-03-06 Thread Christophe LEROY
Le 06/03/2018 à 14:25, Nicholas Piggin a écrit : This converts the slice_mask bit operation helpers to be the usual 3-operand kind, which is clearer to work with. What's the real benefit of doing that ? It is helps for a subsequent patch, say it. Otherwise, I really can't see the point.

[PATCH 07/10] powerpc/mm/slice: Switch to 3-operand slice bitops helpers

2018-03-06 Thread Nicholas Piggin
This converts the slice_mask bit operation helpers to be the usual 3-operand kind, which is clearer to work with. Signed-off-by: Nicholas Piggin --- arch/powerpc/mm/slice.c | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(-) diff