Re: [PATCH 1/1] irq: Maintain user set affinity

2008-11-08 Thread Yinghai Lu
On Tue, Nov 4, 2008 at 8:31 AM, Kumar Gala [EMAIL PROTECTED] wrote: From 819ad3ed4660f4238e053728a8b5aa93d22b13d7 Mon Sep 17 00:00:00 2001 From: Kumar Gala [EMAIL PROTECTED] Date: Tue, 4 Nov 2008 10:13:53 -0600 Subject: [PATCH 1/1] irq: Maintain user set affinity This addresses a regression

Re: [PATCH 1/1] irq: Maintain user set affinity

2008-11-08 Thread Yinghai Lu
Subject: [PATCH 1/1] irq: Maintain user set affinity This addresses a regression in that if a user specified an affinity for an interrupt that affinity information would get reset between a request_irq(), free_irq() and request_irq() for the same irq. ... Are you able to identify when

Re: [PATCH 1/1] irq: Maintain user set affinity

2008-11-08 Thread Benjamin Herrenschmidt
: Maintain user set affinity This addresses a regression in that if a user specified an affinity for an interrupt that affinity information would get reset between a request_irq(), free_irq() and request_irq() for the same irq. On example of this is bringing up an ethernet interface

Re: [PATCH 1/1] irq: Maintain user set affinity

2008-11-08 Thread Yinghai Lu
[EMAIL PROTECTED] Date: Tue, 4 Nov 2008 10:13:53 -0600 Subject: [PATCH 1/1] irq: Maintain user set affinity This addresses a regression in that if a user specified an affinity for an interrupt that affinity information would get reset between a request_irq(), free_irq() and request_irq

Re: [PATCH 1/1] irq: Maintain user set affinity

2008-11-08 Thread Benjamin Herrenschmidt
for MSI, affinity is set two times. also in dynamic_irq_init is setting with #ifdef CONFIG_SMP cpus_setall(desc-affinity); #endif it seems should use irq_default_affinity instead of CPU_MASK_ALL directly there. That sounds more like it. Cheers, Ben.

Re: [PATCH 1/1] irq: Maintain user set affinity

2008-11-06 Thread Andrew Morton
On Tue, 4 Nov 2008 10:31:05 -0600 (CST) Kumar Gala [EMAIL PROTECTED] wrote: From 819ad3ed4660f4238e053728a8b5aa93d22b13d7 Mon Sep 17 00:00:00 2001 From: Kumar Gala [EMAIL PROTECTED] Date: Tue, 4 Nov 2008 10:13:53 -0600 Subject: [PATCH 1/1] irq: Maintain user set affinity This addresses

Re: [PATCH 1/1] irq: Maintain user set affinity

2008-11-06 Thread Kumar Gala
] irq: Maintain user set affinity This addresses a regression in that if a user specified an affinity for an interrupt that affinity information would get reset between a request_irq(), free_irq() and request_irq() for the same irq. On example of this is bringing up an ethernet interface, taking