Re: [PATCH 1/2] ASoC: fsl_mqs: move of_node_put() to the correct location

2023-04-17 Thread Mark Brown
On Mon, 03 Apr 2023 23:26:47 +0800, Liliang Ye wrote: > of_node_put() should have been done directly after > mqs_priv->regmap = syscon_node_to_regmap(gpr_np); > otherwise it creates a reference leak on the success path. > > To fix this, of_node_put() is moved to the correct location, and change >

[PATCH 1/2] ASoC: fsl_mqs: move of_node_put() to the correct location

2023-04-03 Thread Liliang Ye
of_node_put() should have been done directly after mqs_priv->regmap = syscon_node_to_regmap(gpr_np); otherwise it creates a reference leak on the success path. To fix this, of_node_put() is moved to the correct location, and change all the gotos to direct returns. Fixes: a9d273671440 ("ASoC:

Re: [PATCH 1/2] ASoC: fsl_mqs: move of_node_put() to the correct location

2023-04-03 Thread Dan Carpenter
On Mon, Apr 03, 2023 at 11:26:47PM +0800, Liliang Ye wrote: > of_node_put() should have been done directly after > mqs_priv->regmap = syscon_node_to_regmap(gpr_np); > otherwise it creates a reference leak on the success path. > > To fix this, of_node_put() is moved to the correct location, and