Re: [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header

2019-10-25 Thread Michal Simek
On 24. 10. 19 16:44, Masahiro Yamada wrote: > On Thu, Oct 24, 2019 at 7:13 PM Michal Simek wrote: >> >> msi.h is generic for all architectures expect of x86 which has own version. > > Maybe a typo? "except" unfortunately yes. > > > Anyway, the code looks good to me. > > Reviewed-by:

Re: [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header

2019-10-24 Thread Paul Walmsley
On Thu, 24 Oct 2019, Michal Simek wrote: > msi.h is generic for all architectures expect of x86 which has own version. > Enabling MSI by including msi.h to architecture Kbuild is just additional > step which doesn't need to be done. > The patch was created based on request to enable MSI for

Re: [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header

2019-10-24 Thread Masahiro Yamada
On Thu, Oct 24, 2019 at 7:13 PM Michal Simek wrote: > > msi.h is generic for all architectures expect of x86 which has own version. Maybe a typo? "except" Anyway, the code looks good to me. Reviewed-by: Masahiro Yamada > Enabling MSI by including msi.h to architecture Kbuild is just

[PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header

2019-10-24 Thread Michal Simek
msi.h is generic for all architectures expect of x86 which has own version. Enabling MSI by including msi.h to architecture Kbuild is just additional step which doesn't need to be done. The patch was created based on request to enable MSI for Microblaze. Suggested-by: Christoph Hellwig