Re: [PATCH 1/2] powerpc/8xx: Fix NR_IRQ bugs and refactor 8xx interrupt controller

2012-04-19 Thread Grant Likely
On Tue, 17 Apr 2012 09:03:02 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2012-04-16 at 14:13 -0600, Grant Likely wrote: > > The mpc8xx driver uses a reference to NR_IRQS that is buggy. It uses > > NR_IRQs for the array size of the ppc_cached_irq_mask bitmap, but > > NR_IRQs could be smaller t

Re: [PATCH 1/2] powerpc/8xx: Fix NR_IRQ bugs and refactor 8xx interrupt controller

2012-04-16 Thread Joakim Tjernlund
Benjamin Herrenschmidt wrote on 2012/04/17 03:00:40: > > On Tue, 2012-04-17 at 02:03 +0200, Joakim Tjernlund wrote: > > > > If you are going to test 8xx, could you revert > > e0908085fc2391c85b85fb814ae1df377c8e0dcb, > > powerpc/8xx: Fix regression introduced by cache coherency rewrite ? > > > > I

Re: [PATCH 1/2] powerpc/8xx: Fix NR_IRQ bugs and refactor 8xx interrupt controller

2012-04-16 Thread Benjamin Herrenschmidt
On Tue, 2012-04-17 at 02:03 +0200, Joakim Tjernlund wrote: > > If you are going to test 8xx, could you revert > e0908085fc2391c85b85fb814ae1df377c8e0dcb, > powerpc/8xx: Fix regression introduced by cache coherency rewrite ? > > It should not be needed after I fixed up the 8xx TLB code and added a

Re: [PATCH 1/2] powerpc/8xx: Fix NR_IRQ bugs and refactor 8xx interrupt controller

2012-04-16 Thread Joakim Tjernlund
> > On Mon, 2012-04-16 at 14:13 -0600, Grant Likely wrote: > > Ben, I can take these two patches via my irqdomain tree if you prefer. > > Let me give them a test run first. Hi Ben If you are going to test 8xx, could you revert e0908085fc2391c85b85fb814ae1df377c8e0dcb, powerpc/8xx: Fix regression

Re: [PATCH 1/2] powerpc/8xx: Fix NR_IRQ bugs and refactor 8xx interrupt controller

2012-04-16 Thread Grant Likely
On Mon, Apr 16, 2012 at 5:03 PM, Benjamin Herrenschmidt wrote: > On Mon, 2012-04-16 at 14:13 -0600, Grant Likely wrote: >> The mpc8xx driver uses a reference to NR_IRQS that is buggy.  It uses >> NR_IRQs for the array size of the ppc_cached_irq_mask bitmap, but >> NR_IRQs could be smaller than the

Re: [PATCH 1/2] powerpc/8xx: Fix NR_IRQ bugs and refactor 8xx interrupt controller

2012-04-16 Thread Grant Likely
On Mon, Apr 16, 2012 at 5:03 PM, Benjamin Herrenschmidt wrote: > On Mon, 2012-04-16 at 14:13 -0600, Grant Likely wrote: >> Ben, I can take these two patches via my irqdomain tree if you prefer. > > Let me give them a test run first. Yes of course. I won't merge before they've been checked out.

Re: [PATCH 1/2] powerpc/8xx: Fix NR_IRQ bugs and refactor 8xx interrupt controller

2012-04-16 Thread Benjamin Herrenschmidt
On Mon, 2012-04-16 at 14:13 -0600, Grant Likely wrote: > Ben, I can take these two patches via my irqdomain tree if you prefer. Let me give them a test run first. Cheers, Ben. > g. > > On Mon, Apr 16, 2012 at 2:13 PM, Grant Likely > wrote: > > The mpc8xx driver uses a reference to NR_IRQS tha

Re: [PATCH 1/2] powerpc/8xx: Fix NR_IRQ bugs and refactor 8xx interrupt controller

2012-04-16 Thread Benjamin Herrenschmidt
On Mon, 2012-04-16 at 14:13 -0600, Grant Likely wrote: > The mpc8xx driver uses a reference to NR_IRQS that is buggy. It uses > NR_IRQs for the array size of the ppc_cached_irq_mask bitmap, but > NR_IRQs could be smaller than the number of hardware irqs that > ppc_cached_irq_mask tracks. > > Also

Re: [PATCH 1/2] powerpc/8xx: Fix NR_IRQ bugs and refactor 8xx interrupt controller

2012-04-16 Thread Grant Likely
Ben, I can take these two patches via my irqdomain tree if you prefer. g. On Mon, Apr 16, 2012 at 2:13 PM, Grant Likely wrote: > The mpc8xx driver uses a reference to NR_IRQS that is buggy.  It uses > NR_IRQs for the array size of the ppc_cached_irq_mask bitmap, but > NR_IRQs could be smaller th

[PATCH 1/2] powerpc/8xx: Fix NR_IRQ bugs and refactor 8xx interrupt controller

2012-04-16 Thread Grant Likely
The mpc8xx driver uses a reference to NR_IRQS that is buggy. It uses NR_IRQs for the array size of the ppc_cached_irq_mask bitmap, but NR_IRQs could be smaller than the number of hardware irqs that ppc_cached_irq_mask tracks. Also, while fixing that problem, it became apparent that the interrupt