Re: [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-04-01 Thread Wolfgang Grandegger
David Gibson wrote: On Tue, Mar 31, 2009 at 02:43:39PM +0200, Wolfgang Grandegger wrote: The I2c node property fsl,preserve-clocking allows to overtake the clock settings from the boot loader and avoids the hard-coded setting. Hrm. This is dubious. The device tree should generally describe

Re: [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-04-01 Thread David Gibson
On Wed, Apr 01, 2009 at 09:40:13AM +0200, Wolfgang Grandegger wrote: David Gibson wrote: On Tue, Mar 31, 2009 at 02:43:39PM +0200, Wolfgang Grandegger wrote: The I2c node property fsl,preserve-clocking allows to overtake the clock settings from the boot loader and avoids the hard-coded

[PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Wolfgang Grandegger
The I2c node property fsl,preserve-clocking allows to overtake the clock settings from the boot loader and avoids the hard-coded setting. Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- drivers/i2c/busses/i2c-mpc.c | 24 1 file changed, 16 insertions(+), 8

Re: [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Wolfram Sang
On Tue, Mar 31, 2009 at 02:50:29PM +0200, Wolfgang Grandegger wrote: The I2c node property fsl,preserve-clocking allows to overtake the clock settings from the boot loader and avoids the hard-coded setting. Signed-off-by: Wolfgang Grandegger w...@grandegger.com ---

[PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Wolfgang Grandegger
The I2c node property fsl,preserve-clocking allows to overtake the clock settings from the boot loader and avoids the hard-coded setting. Signed-off-by: Wolfgang Grandegger w...@grandegger.com --- drivers/i2c/busses/i2c-mpc.c | 24 1 file changed, 16 insertions(+), 8

Re: [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Wolfgang Grandegger
Wolfram Sang wrote: On Tue, Mar 31, 2009 at 02:50:29PM +0200, Wolfgang Grandegger wrote: The I2c node property fsl,preserve-clocking allows to overtake the clock settings from the boot loader and avoids the hard-coded setting. Signed-off-by: Wolfgang Grandegger w...@grandegger.com ---

Re: [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Wolfram Sang
- - mpc_i2c_setclock(i2c); + + if (set_clock) + mpc_i2c_setclock(i2c); Can't we drop 'set_clock' with something like this here? + if (!of_get_property(op-node, fsl,preserve-clocking, NULL)) { + + if (of_get_property(op-node, dfsrr, NULL)) +

Re: [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Grant Likely
2009/3/31 Wolfram Sang w.s...@pengutronix.de: - -  mpc_i2c_setclock(i2c); + +  if (set_clock) +          mpc_i2c_setclock(i2c); Can't we drop 'set_clock' with something like this here? +   if (!of_get_property(op-node, fsl,preserve-clocking, NULL)) { + +           if

Re: [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Wolfgang Grandegger
Grant Likely wrote: 2009/3/31 Wolfram Sang w.s...@pengutronix.de: - - mpc_i2c_setclock(i2c); + + if (set_clock) + mpc_i2c_setclock(i2c); Can't we drop 'set_clock' with something like this here? + if (!of_get_property(op-node, fsl,preserve-clocking, NULL)) { + + if

Re: [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread David Gibson
On Tue, Mar 31, 2009 at 02:43:39PM +0200, Wolfgang Grandegger wrote: The I2c node property fsl,preserve-clocking allows to overtake the clock settings from the boot loader and avoids the hard-coded setting. Hrm. This is dubious. The device tree should generally describe hardware, not