Re: [PATCH 1/2] rtc: rtc-ds1374: fix 'no irq' case handling

2008-08-19 Thread Alan Cox
> I don't know the status of these platforms > > asm-blackfin/irq.h:#define NO_IRQ ((unsigned int)(-1)) > asm-mn10300/irq.h:#define NO_IRQ INT_MAX > asm-parisc/irq.h:#define NO_IRQ (-1) In need of fixing, assuming they actually use NO_IRQ for anything - don't be mis

Re: [PATCH 1/2] rtc: rtc-ds1374: fix 'no irq' case handling

2008-08-19 Thread Jon Smirl
On 8/19/08, Alan Cox <[EMAIL PROTECTED]> wrote: > > Shouldn't this be > > > > > - if (client->irq <= NO_IRQ) > > > > instead of > > > NO_IRQ is obsolete. client->irq != is the test and IRQ numbers are > unsigned. I don't know the status of these platforms asm-blackfin/irq.h:#defin

Re: [PATCH 1/2] rtc: rtc-ds1374: fix 'no irq' case handling

2008-08-19 Thread Anton Vorontsov
On Tue, Aug 19, 2008 at 04:39:09PM -0400, Jon Smirl wrote: > On 8/12/08, Anton Vorontsov <[EMAIL PROTECTED]> wrote: > > On a PowerPC board with ds1374 RTC I'm getting this error while > > RTC tries to probe: > > > > rtc-ds1374 0-0068: unable to request IRQ > > > > This happens because I2C probin

Re: [PATCH 1/2] rtc: rtc-ds1374: fix 'no irq' case handling

2008-08-19 Thread Alan Cox
> Shouldn't this be > > > - if (client->irq <= NO_IRQ) > > instead of NO_IRQ is obsolete. client->irq != is the test and IRQ numbers are unsigned. Alan ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/li

Re: [PATCH 1/2] rtc: rtc-ds1374: fix 'no irq' case handling

2008-08-19 Thread Jon Smirl
On 8/12/08, Anton Vorontsov <[EMAIL PROTECTED]> wrote: > On a PowerPC board with ds1374 RTC I'm getting this error while > RTC tries to probe: > > rtc-ds1374 0-0068: unable to request IRQ > > This happens because I2C probing code (drivers/of/of_i2c.c) is > specifying IRQ0 for 'no irq' case, whi

Re: [PATCH 1/2] rtc: rtc-ds1374: fix 'no irq' case handling

2008-08-19 Thread Peter Korsgaard
> "Anton" == Anton Vorontsov <[EMAIL PROTECTED]> writes: Anton> On a PowerPC board with ds1374 RTC I'm getting this error while Anton> RTC tries to probe: Anton> rtc-ds1374 0-0068: unable to request IRQ Anton> This happens because I2C probing code (drivers/of/of_i2c.c) is Anton> specify

[PATCH 1/2] rtc: rtc-ds1374: fix 'no irq' case handling

2008-08-12 Thread Anton Vorontsov
On a PowerPC board with ds1374 RTC I'm getting this error while RTC tries to probe: rtc-ds1374 0-0068: unable to request IRQ This happens because I2C probing code (drivers/of/of_i2c.c) is specifying IRQ0 for 'no irq' case, which is correct. The driver handles this incorrectly, though. This patch