Re: [PATCH 1/3] mpc83xx: Power Management support

2008-07-02 Thread Kumar Gala
diff --git a/arch/powerpc/platforms/83xx/suspend-asm.S b/arch/ powerpc/platforms/83xx/suspend-asm.S new file mode 100644 index 000..03e29a2 --- /dev/null +++ b/arch/powerpc/platforms/83xx/suspend-asm.S @@ -0,0 +1,539 @@ +/* + * Enter and leave sleep state on MPC83xx + * + * Author: Scott

Re: [PATCH 1/3] mpc83xx: Power Management support

2008-07-02 Thread Scott Wood
Kumar Gala wrote: If we are going to allocate space for save area like this, can't we do this in C code. Its less error prone and easier to extend over time. I know the powermac code does something similar but it places the save area on the stack. Then we'd have to split it between things

Re: [PATCH 1/3] mpc83xx: Power Management support

2008-07-02 Thread Kumar Gala
diff --git a/arch/powerpc/platforms/83xx/suspend-asm.S b/arch/ powerpc/platforms/83xx/suspend-asm.S new file mode 100644 index 000..03e29a2 --- /dev/null +++ b/arch/powerpc/platforms/83xx/suspend-asm.S @@ -0,0 +1,539 @@ +/* + * Enter and leave sleep state on MPC83xx + * + * Author: Scott

Re: [PATCH 1/3] mpc83xx: Power Management support

2008-07-02 Thread Scott Wood
Kumar Gala wrote: +#define SS_MEMSAVE0x00 What is this? add a comment? There's a comment where MEMSAVE is used: /* The first 2 words of memory are used to communicate with the * bootloader, to tell it how to resume. * * The first word is the magic

Re: [PATCH 1/3] mpc83xx: Power Management support

2008-07-02 Thread Scott Wood
Kumar Gala wrote: On Jul 2, 2008, at 12:12 PM, Scott Wood wrote: Kumar Gala wrote: +#define SS_MEMSAVE0x00 What is this? add a comment? There's a comment where MEMSAVE is used: /* The first 2 words of memory are used to communicate with the I read this as the memory address

Re: [PATCH 1/3] mpc83xx: Power Management support

2008-06-26 Thread Kumar Gala
On Jun 25, 2008, at 4:50 PM, Scott Wood wrote: Basic PM support for 83xx. Standby is implemented as sleep. Suspend-to-RAM is implemented as deep sleep (with the processor turned off) on 831x. PCI agent power management is supported. Device power management of SOC peripherals is not yet

Re: [PATCH 1/3] mpc83xx: Power Management support

2008-06-26 Thread Scott Wood
Kumar Gala wrote: On Jun 25, 2008, at 4:50 PM, Scott Wood wrote: Basic PM support for 83xx. Standby is implemented as sleep. Suspend-to-RAM is implemented as deep sleep (with the processor turned off) on 831x. PCI agent power management is supported. Device power management of SOC

RE: [PATCH 1/3] mpc83xx: Power Management support

2008-06-26 Thread Liu Dave
Basic PM support for 83xx. Standby is implemented as sleep. Suspend-to-RAM is implemented as deep sleep (with the processor turned off) on 831x. PCI agent power management is supported. Device power management of SOC peripherals is not yet supported. (Not comments on this patch, but

Re: [PATCH 1/3] mpc83xx: Power Management support

2008-06-26 Thread Kumar Gala
On Jun 26, 2008, at 9:39 AM, Liu Dave wrote: Basic PM support for 83xx. Standby is implemented as sleep. Suspend-to-RAM is implemented as deep sleep (with the processor turned off) on 831x. PCI agent power management is supported. Device power management of SOC peripherals is not yet

[PATCH 1/3] mpc83xx: Power Management support

2008-06-25 Thread Scott Wood
Basic PM support for 83xx. Standby is implemented as sleep. Suspend-to-RAM is implemented as deep sleep (with the processor turned off) on 831x. PCI agent power management is supported. Device power management of SOC peripherals is not yet supported. Signed-off-by: Scott Wood [EMAIL PROTECTED]