Re: [PATCH 1/3] powerpc/smp: Reintroduce cpu_core_mask

2021-04-18 Thread David Gibson
On Fri, Apr 16, 2021 at 11:15:49AM +0530, Srikar Dronamraju wrote: > * David Gibson [2021-04-16 13:21:34]: > > Thanks for having a look at the patches. > > > On Thu, Apr 15, 2021 at 05:39:32PM +0530, Srikar Dronamraju wrote: > > > Daniel reported that with Commit 4ca234a9cbd7 ("powerpc/smp:

Re: [PATCH 1/3] powerpc/smp: Reintroduce cpu_core_mask

2021-04-15 Thread Srikar Dronamraju
* David Gibson [2021-04-16 13:21:34]: Thanks for having a look at the patches. > On Thu, Apr 15, 2021 at 05:39:32PM +0530, Srikar Dronamraju wrote: > > Daniel reported that with Commit 4ca234a9cbd7 ("powerpc/smp: Stop > > updating cpu_core_mask") QEMU was unable to set single NUMA node SMP > >

Re: [PATCH 1/3] powerpc/smp: Reintroduce cpu_core_mask

2021-04-15 Thread David Gibson
On Thu, Apr 15, 2021 at 05:39:32PM +0530, Srikar Dronamraju wrote: > Daniel reported that with Commit 4ca234a9cbd7 ("powerpc/smp: Stop > updating cpu_core_mask") QEMU was unable to set single NUMA node SMP > topologies such as: > -smp 8,maxcpus=8,cores=2,threads=2,sockets=2 > i.e he expected 2

Re: [PATCH 1/3] powerpc/smp: Reintroduce cpu_core_mask

2021-04-15 Thread Srikar Dronamraju
* Gautham R Shenoy [2021-04-15 22:41:34]: > Hi Srikar, > > Thanks for taking a look. > > @@ -1485,12 +1486,36 @@ static void add_cpu_to_masks(int cpu) > > add_cpu_to_smallcore_masks(cpu); > > > > /* In CPU-hotplug path, hence use GFP_ATOMIC */ > > - alloc_cpumask_var_node(,

Re: [PATCH 1/3] powerpc/smp: Reintroduce cpu_core_mask

2021-04-15 Thread Gautham R Shenoy
Hi Srikar, On Thu, Apr 15, 2021 at 05:39:32PM +0530, Srikar Dronamraju wrote: [..snip..] > @@ -1485,12 +1486,36 @@ static void add_cpu_to_masks(int cpu) > add_cpu_to_smallcore_masks(cpu); > > /* In CPU-hotplug path, hence use GFP_ATOMIC */ > - alloc_cpumask_var_node(,

[PATCH 1/3] powerpc/smp: Reintroduce cpu_core_mask

2021-04-15 Thread Srikar Dronamraju
Daniel reported that with Commit 4ca234a9cbd7 ("powerpc/smp: Stop updating cpu_core_mask") QEMU was unable to set single NUMA node SMP topologies such as: -smp 8,maxcpus=8,cores=2,threads=2,sockets=2 i.e he expected 2 sockets in one NUMA node. The above commit helped to reduce boot time on