Re: [PATCH 1/3] powerpc: mm: make _PAGE_NUMA take effect

2013-12-11 Thread Liu ping fan
On Thu, Dec 5, 2013 at 6:53 PM, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: Liu Ping Fan kernelf...@gmail.com writes: To enable the do_numa_page(), we should not fix _PAGE_NUMA in hash_page(), so bail out for the case of pte_numa(). Signed-off-by: Liu Ping Fan

Re: [PATCH 1/3] powerpc: mm: make _PAGE_NUMA take effect

2013-12-11 Thread Benjamin Herrenschmidt
On Wed, 2013-12-11 at 16:50 +0800, Liu ping fan wrote: why ? , All the hash routines do check for _PAGE_PRESENT via access variable. Going through __hash_page_4K(4k on 4k HW), I do not find such check. Am I wrong? Or I will send out a patch to fix that. We pass a bitmask of flags to check

Re: [PATCH 1/3] powerpc: mm: make _PAGE_NUMA take effect

2013-12-11 Thread Liu ping fan
On Wed, Dec 11, 2013 at 5:50 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Wed, 2013-12-11 at 16:50 +0800, Liu ping fan wrote: why ? , All the hash routines do check for _PAGE_PRESENT via access variable. Going through __hash_page_4K(4k on 4k HW), I do not find such check.

Re: [PATCH 1/3] powerpc: mm: make _PAGE_NUMA take effect

2013-12-08 Thread Benjamin Herrenschmidt
On Thu, 2013-12-05 at 16:23 +0530, Aneesh Kumar K.V wrote: Liu Ping Fan kernelf...@gmail.com writes: To enable the do_numa_page(), we should not fix _PAGE_NUMA in hash_page(), so bail out for the case of pte_numa(). For some reason I don't have 2/3 and 3/3 in my mbox (though I do have them

Re: [PATCH 1/3] powerpc: mm: make _PAGE_NUMA take effect

2013-12-08 Thread Liu ping fan
On Mon, Dec 9, 2013 at 8:31 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Thu, 2013-12-05 at 16:23 +0530, Aneesh Kumar K.V wrote: Liu Ping Fan kernelf...@gmail.com writes: To enable the do_numa_page(), we should not fix _PAGE_NUMA in hash_page(), so bail out for the case of

Re: [PATCH 1/3] powerpc: mm: make _PAGE_NUMA take effect

2013-12-08 Thread Benjamin Herrenschmidt
On Mon, 2013-12-09 at 14:17 +0800, Liu ping fan wrote: On Mon, Dec 9, 2013 at 8:31 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Thu, 2013-12-05 at 16:23 +0530, Aneesh Kumar K.V wrote: Liu Ping Fan kernelf...@gmail.com writes: To enable the do_numa_page(), we should not

Re: [PATCH 1/3] powerpc: mm: make _PAGE_NUMA take effect

2013-12-05 Thread Aneesh Kumar K.V
Liu Ping Fan kernelf...@gmail.com writes: To enable the do_numa_page(), we should not fix _PAGE_NUMA in hash_page(), so bail out for the case of pte_numa(). Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- arch/powerpc/mm/hash_utils_64.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH 1/3] powerpc: mm: make _PAGE_NUMA take effect

2013-12-03 Thread Liu Ping Fan
To enable the do_numa_page(), we should not fix _PAGE_NUMA in hash_page(), so bail out for the case of pte_numa(). Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- arch/powerpc/mm/hash_utils_64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git