Re: [PATCH 1/4] allow arch specific function for allocating gigantic pages

2008-03-26 Thread Andi Kleen
Haven't reviewed it in detail, just noticed something. > @@ -614,6 +610,7 @@ static int __init hugetlb_init(void) > { > if (HPAGE_SHIFT == 0) > return 0; > + INIT_LIST_HEAD(&huge_boot_pages); > return hugetlb_init_hstate(&global_hstate); I don't think adding the IN

[PATCH 1/4] allow arch specific function for allocating gigantic pages

2008-03-26 Thread Jon Tollefson
Allow alloc_bm_huge_page() to be overridden by architectures that can't always use bootmem. This requires huge_boot_pages to be available for use by this function. Also huge_page_size() and other functions need to use a long so that they can handle the 16G page size. Signed-off-by: Jon Tollef