Re: [PATCH 1/4] kdump : add support for ibm, dynamic-reconfiguration-memory for kexec/kdump

2008-07-11 Thread Chandru
On Friday 11 July 2008 03:57:53 Nathan Fontenot wrote: Hello Chandru, static int __init early_init_dt_scan_drconf_memory(unsigned long node) { - cell_t *dm, *ls; + cell_t *dm, *ls, *endp, *usm; unsigned long l, n, flags; u64 base, size, lmb_size; + char buf[32],

Re: [PATCH 1/4] kdump : add support for ibm, dynamic-reconfiguration-memory for kexec/kdump

2008-07-10 Thread Nathan Fontenot
Hello Chandru, static int __init early_init_dt_scan_drconf_memory(unsigned long node) { - cell_t *dm, *ls; + cell_t *dm, *ls, *endp, *usm; unsigned long l, n, flags; u64 base, size, lmb_size; + char buf[32], t[8]; ls = (cell_t *)of_get_flat_dt_prop(node,

Re: [PATCH 1/4] kdump : add support for ibm, dynamic-reconfiguration-memory for kexec/kdump

2008-07-08 Thread Chandru
Thanks for the review comments. I will change to 'snprintf' at all the places and remove the unnecessary casts. On Tuesday 08 July 2008 07:06:46 Stephen Rothwell wrote: Hi Chandru, On Tue, 8 Jul 2008 00:14:24 +0530 Chandru [EMAIL PROTECTED] wrote: + if (usm != NULL) { +

[PATCH 1/4] kdump : add support for ibm, dynamic-reconfiguration-memory for kexec/kdump

2008-07-07 Thread Chandru
kexec-tools adds crash, rtas, and tce memory regions as linux,usable-memory properties in device-tree. Following changes are made in the kernel to recognize these special properties in case of ibm,dynamic-reconfiguration-memory node of device-tree. Signed-off-by: Chandru Siddalingappa [EMAIL

Re: [PATCH 1/4] kdump : add support for ibm, dynamic-reconfiguration-memory for kexec/kdump

2008-07-07 Thread Stephen Rothwell
Hi Chandru, On Tue, 8 Jul 2008 00:14:24 +0530 Chandru [EMAIL PROTECTED] wrote: @@ -917,7 +918,33 @@ static int __init early_init_dt_scan_drc if ((base + size) 0x8000ul) size = 0x8000ul - base; } -