Re: [PATCH 1/5] of: Add support for linking device tree blobs into vmlinux

2010-11-17 Thread Sam Ravnborg
On Tue, Nov 16, 2010 at 02:41:36PM -0800, dirk.brande...@gmail.com wrote: From: Dirk Brandewie dirk.brande...@gmail.com This patch adds support for linking device tree blobs into vmlinux. Modifies asm-generic/vmlinux.lds.h to add linking .dtb.init.rodata sections into the .init.data section

Re: [PATCH 1/5] of: Add support for linking device tree blobs into vmlinux

2010-11-17 Thread David Daney
On 11/16/2010 10:14 PM, Dirk Brandewie wrote: On 11/16/2010 06:58 PM, Grant Likely wrote: On Tue, Nov 16, 2010 at 7:21 PM, Dirk Brandewie dirk.brande...@gmail.com wrote: On 11/16/2010 04:39 PM, David Daney wrote: Thanks for doing this. However I have a few comments... On 11/16/2010 02:41

Re: [PATCH 1/5] of: Add support for linking device tree blobs into vmlinux

2010-11-17 Thread Grant Likely
On Wed, Nov 17, 2010 at 10:27:51AM +0100, Sam Ravnborg wrote: On Tue, Nov 16, 2010 at 02:41:36PM -0800, dirk.brande...@gmail.com wrote: From: Dirk Brandewie dirk.brande...@gmail.com This patch adds support for linking device tree blobs into vmlinux. Modifies asm-generic/vmlinux.lds.h to

Re: [PATCH 1/5] of: Add support for linking device tree blobs into vmlinux

2010-11-17 Thread Sam Ravnborg
+ +DTC = $(objtree)/scripts/dtc/dtc + +quiet_cmd_dtc = DTC $@ Please avoid tabs in the output - all other uses spaces. (There is a tab between DTC and $@) + cmd_dtc = $(DTC) -O dtb -o $(obj)/$*.dtb -b 0 $(DTS_FLAGS) $(src)/dts/$*.dts Looks strange. How

[PATCH 1/5] of: Add support for linking device tree blobs into vmlinux

2010-11-16 Thread dirk . brandewie
From: Dirk Brandewie dirk.brande...@gmail.com This patch adds support for linking device tree blobs into vmlinux. Modifies asm-generic/vmlinux.lds.h to add linking .dtb.init.rodata sections into the .init.data section of the vmlinux image. Modifies scripts/Makefile.lib to add a kbuild command to

Re: [PATCH 1/5] of: Add support for linking device tree blobs into vmlinux

2010-11-16 Thread David Daney
Thanks for doing this. However I have a few comments... On 11/16/2010 02:41 PM, dirk.brande...@gmail.com wrote: From: Dirk Brandewiedirk.brande...@gmail.com This patch adds support for linking device tree blobs into vmlinux. Modifies asm-generic/vmlinux.lds.h to add linking .dtb.init.rodata

Re: [PATCH 1/5] of: Add support for linking device tree blobs into vmlinux

2010-11-16 Thread Dirk Brandewie
On 11/16/2010 04:39 PM, David Daney wrote: Thanks for doing this. However I have a few comments... On 11/16/2010 02:41 PM, dirk.brande...@gmail.com wrote: From: Dirk Brandewiedirk.brande...@gmail.com /* .data section */ #define DATA_DATA \ *(.data) \ @@ -468,7 +482,8 @@ MCOUNT_REC() \

Re: [PATCH 1/5] of: Add support for linking device tree blobs into vmlinux

2010-11-16 Thread Grant Likely
On Tue, Nov 16, 2010 at 7:21 PM, Dirk Brandewie dirk.brande...@gmail.com wrote: On 11/16/2010 04:39 PM, David Daney wrote: Thanks for doing this. However I have a few comments... On 11/16/2010 02:41 PM, dirk.brande...@gmail.com wrote: From: Dirk Brandewiedirk.brande...@gmail.com /* .data

Re: [PATCH 1/5] of: Add support for linking device tree blobs into vmlinux

2010-11-16 Thread Dirk Brandewie
On 11/16/2010 06:58 PM, Grant Likely wrote: On Tue, Nov 16, 2010 at 7:21 PM, Dirk Brandewie dirk.brande...@gmail.com wrote: On 11/16/2010 04:39 PM, David Daney wrote: Thanks for doing this. However I have a few comments... On 11/16/2010 02:41 PM, dirk.brande...@gmail.com wrote: From: