Re: [PATCH 1/5] powerpc/qe: Implement QE Pin Multiplexing API

2008-12-17 Thread Kumar Gala
Kumar, can you please merge this patch? It is the last patch that holds the FHCI USB driver. Thanks, Will do. Can I get you to add kdoc comments for the API functions: The functions already have kdoc comments (see qe_lib/gpio.c changes). Yeah, I noticed that.. sorry about the noise. -

Re: [PATCH 1/5] powerpc/qe: Implement QE Pin Multiplexing API

2008-12-17 Thread Anton Vorontsov
On Wed, Dec 17, 2008 at 10:46:17AM -0600, Kumar Gala wrote: > > On Dec 17, 2008, at 9:41 AM, Anton Vorontsov wrote: > >> On Wed, Dec 03, 2008 at 10:27:38PM +0300, Anton Vorontsov wrote: >>> With this API we're able to set a QE pin to the GPIO mode or a >>> dedicated >>> peripheral function. >>> >

Re: [PATCH 1/5] powerpc/qe: Implement QE Pin Multiplexing API

2008-12-17 Thread Kumar Gala
On Dec 3, 2008, at 1:27 PM, Anton Vorontsov wrote: With this API we're able to set a QE pin to the GPIO mode or a dedicated peripheral function. The API relies on the fact that QE gpio controllers are registered. If they aren't, the API won't work (gracefully though). There is one caveat th

Re: [PATCH 1/5] powerpc/qe: Implement QE Pin Multiplexing API

2008-12-17 Thread Kumar Gala
On Dec 17, 2008, at 9:41 AM, Anton Vorontsov wrote: On Wed, Dec 03, 2008 at 10:27:38PM +0300, Anton Vorontsov wrote: With this API we're able to set a QE pin to the GPIO mode or a dedicated peripheral function. The API relies on the fact that QE gpio controllers are registered. If they a

Re: [PATCH 1/5] powerpc/qe: Implement QE Pin Multiplexing API

2008-12-17 Thread Anton Vorontsov
On Wed, Dec 03, 2008 at 10:27:38PM +0300, Anton Vorontsov wrote: > With this API we're able to set a QE pin to the GPIO mode or a dedicated > peripheral function. > > The API relies on the fact that QE gpio controllers are registered. If > they aren't, the API won't work (gracefully though). > >

[PATCH 1/5] powerpc/qe: Implement QE Pin Multiplexing API

2008-12-03 Thread Anton Vorontsov
With this API we're able to set a QE pin to the GPIO mode or a dedicated peripheral function. The API relies on the fact that QE gpio controllers are registered. If they aren't, the API won't work (gracefully though). There is one caveat though: if anybody occupied the node->data before us, or ov