Re: [PATCH 1/6] perf_counter: powerpc: Enable use of software counters on 32-bit powerpc

2009-06-20 Thread Ingo Molnar
* Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Wed, 2009-06-17 at 16:27 +0200, Ingo Molnar wrote: I think it would be nice to have more platform support in .31. Perfcounters is a brand-new feature so there's no risk of regression. In the end it will depend on Linus to pull

Re: [PATCH 1/6] perf_counter: powerpc: Enable use of software counters on 32-bit powerpc

2009-06-18 Thread Ingo Molnar
* Paul Mackerras pau...@samba.org wrote: Ingo Molnar writes: Note, i've created a new branch, tip:perfcounters/powerpc, so we can keep these things separate and Ben can pull them too. I see there was some review feedback - do you want to send a v2 version perhaps? Kumar's comments

Re: [PATCH 1/6] perf_counter: powerpc: Enable use of software counters on 32-bit powerpc

2009-06-18 Thread Benjamin Herrenschmidt
On Wed, 2009-06-17 at 16:21 +0200, Ingo Molnar wrote: This depends on the generic atomic64_t patches, which are now in Linus' tree. Ingo, if you're putting these in, please pull Linus' tree in first. Note, i've created a new branch, tip:perfcounters/powerpc, so we can keep these

Re: [PATCH 1/6] perf_counter: powerpc: Enable use of software counters on 32-bit powerpc

2009-06-18 Thread Benjamin Herrenschmidt
On Wed, 2009-06-17 at 16:27 +0200, Ingo Molnar wrote: I think it would be nice to have more platform support in .31. Perfcounters is a brand-new feature so there's no risk of regression. In the end it will depend on Linus to pull of course, and BenH can veto it too if he'd like no more

[PATCH 1/6] perf_counter: powerpc: Enable use of software counters on 32-bit powerpc

2009-06-17 Thread Paul Mackerras
This enables the perf_counter subsystem on 32-bit powerpc. Since we don't have any support for hardware counters on 32-bit powerpc yet, only software counters can be used. Besides selecting HAVE_PERF_COUNTERS for 32-bit powerpc as well as 64-bit, the main thing this does is add an implementation

Re: [PATCH 1/6] perf_counter: powerpc: Enable use of software counters on 32-bit powerpc

2009-06-17 Thread Ingo Molnar
* Paul Mackerras pau...@samba.org wrote: This depends on the generic atomic64_t patches, which are now in Linus' tree. Ingo, if you're putting these in, please pull Linus' tree in first. yes, i already did that earlier today - so all should be fine with the lib/atomic64.c dependency.

Re: [PATCH 1/6] perf_counter: powerpc: Enable use of software counters on 32-bit powerpc

2009-06-17 Thread Kumar Gala
On Jun 17, 2009, at 6:50 AM, Paul Mackerras wrote: diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/ platforms/Kconfig.cputype index cca6b4f..dd9f3ec 100644 --- a/arch/powerpc/platforms/Kconfig.cputype +++ b/arch/powerpc/platforms/Kconfig.cputype @@ -1,7 +1,7 @@ config PPC64

Re: [PATCH 1/6] perf_counter: powerpc: Enable use of software counters on 32-bit powerpc

2009-06-17 Thread Ingo Molnar
* Paul Mackerras pau...@samba.org wrote: This depends on the generic atomic64_t patches, which are now in Linus' tree. Ingo, if you're putting these in, please pull Linus' tree in first. Note, i've created a new branch, tip:perfcounters/powerpc, so we can keep these things separate and

Re: [PATCH 1/6] perf_counter: powerpc: Enable use of software counters on 32-bit powerpc

2009-06-17 Thread Kumar Gala
On Jun 17, 2009, at 9:21 AM, Ingo Molnar wrote: * Paul Mackerras pau...@samba.org wrote: This depends on the generic atomic64_t patches, which are now in Linus' tree. Ingo, if you're putting these in, please pull Linus' tree in first. Note, i've created a new branch,

Re: [PATCH 1/6] perf_counter: powerpc: Enable use of software counters on 32-bit powerpc

2009-06-17 Thread Ingo Molnar
* Kumar Gala ga...@kernel.crashing.org wrote: On Jun 17, 2009, at 9:21 AM, Ingo Molnar wrote: * Paul Mackerras pau...@samba.org wrote: This depends on the generic atomic64_t patches, which are now in Linus' tree. Ingo, if you're putting these in, please pull Linus' tree in first.

Re: [PATCH 1/6] perf_counter: powerpc: Enable use of software counters on 32-bit powerpc

2009-06-17 Thread Paul Mackerras
Kumar Gala writes: On Jun 17, 2009, at 6:50 AM, Paul Mackerras wrote: +config PPC_HAVE_PMU_SUPPORT + bool what does this mean? At the moment it means that arch/powerpc/kernel/perf_counters.c works for at least some processors in the selected processor family. + +config

Re: [PATCH 1/6] perf_counter: powerpc: Enable use of software counters on 32-bit powerpc

2009-06-17 Thread Paul Mackerras
Ingo Molnar writes: Note, i've created a new branch, tip:perfcounters/powerpc, so we can keep these things separate and Ben can pull them too. I see there was some review feedback - do you want to send a v2 version perhaps? Kumar's comments seemed to me to be wanting changes to accommodate